public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32
Date: Tue, 02 Nov 2010 17:34:36 +0100	[thread overview]
Message-ID: <4CD03D9C.6070703@emk-elektronik.de> (raw)
In-Reply-To: <1288695003-5427-1-git-send-email-biessmann@corscience.de>

Dear Andreas Bie?mann,

Your e-Mail is:
Content-Transfer-Encoding: quoted-printable

That means ' ' comes as =20, '=' comes as =3D

> There was a prototype change from do_bdinfo(.. char *) to do_bdinfo(.. char *
> const). This patch respect this change for AVR32 architecture.
> 
> Signed-off-by: Andreas Bie?mann <biessmann@corscience.de>
> ---
>  common/cmd_bdinfo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index bba7374..1d76ffa 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -304,7 +304,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  
>  #elif defined(CONFIG_AVR32)
>  
> -int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  {
>  	bd_t *bd = gd->bd;
>  

I see that cmd_bdinfo.c has lots of coding style violations, but
some architectures have them fixed.
Could we at least fix them in the AVR32 part, if we touch it anyway?
See the BLACKFIN example ;)

Or is it OK to leave it as is? Wolfgang?

Best Regards,
Reinhard

  reply	other threads:[~2010-11-02 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 10:50 [U-Boot] [PATCH] common/cmd_bdinfo.c: fix do_bdinfo() for AVR32 Andreas Bießmann
2010-11-02 16:34 ` Reinhard Meyer [this message]
2010-11-02 17:01   ` Andreas Bießmann
2010-11-03  9:21     ` Andreas Bießmann
2010-11-02 19:54   ` Wolfgang Denk
2010-11-03  9:14 ` [U-Boot] [PATCH v2 1/3] cmd_bdinfo.c: fix whitespace Andreas Bießmann
2010-11-03  9:14 ` [U-Boot] [PATCH v2 2/3] cmd_bdinfo.c: fix long lines Andreas Bießmann
2010-11-03  9:14 ` [U-Boot] [PATCH v2 3/3] cmd_bdinfo.c: fix do_bdinfo() for AVR32 Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD03D9C.6070703@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox