[U-Boot] [RFC] AT91 cleanup, was: Re: [PATCH 02/11] at91: Add USART & DBGU base address defines

Reinhard Meyer
2010-11-03T10:03:36Z

Andreas Bie?mann schrieb:
> Dear Reinhard Meyer,
> Am 03.11.2010 10:17, schrieb Reinhard Meyer:
>
>> ATMEL_ID_EMAC --> ATMEL_ID_EMAC0
>
> emac? isn't the sam9/avr32 mac called macb?

In AT91 its called EMAC, but uses the MACB driver. Ask ATMEL why it is named
differently :)
The value ATMEL_BASE_EMAC0 is a parameter to the MACB driver, so it does not
matter how it is named.

I try to use the component names as used in the chapter headers of the
datasheets. Where it is likely that there are multiple incarnations of the
same component in the future, I will number the only one with "0".
(There are 2x EMAC variants of the AT91 in the cooker).

>> AVR32 includes "memory-map.h", AT91 did include "hardware.h".
>> I changed that to "memory-map.h" and deleted hardware.h. However
>> including "hardware.h" seems common in other architectures. We could
>> go for hardware.h and adapt the AVR32 case.
>
> I prefer hardware.h, will change avr32 case cause i am currently working
> with avr32 board.

Do you have a ATNGW100 to check changes for that one?
Ok, I will undo the changes and remove "memory-map.h" instead.

>> Finally eliminate all LEGACY definitions in the header files.
>
> would be fine

All in at91sam9260.h have gone already.

Best Regards,
Reinhard