[U-Boot] [PATCH 06/11] at91: Add defines for spi SoC access

Alexander Stein
2010-11-01T08:52:34Z

On Monday 01 November 2010, 09:43:57 Reinhard Meyer wrote:
> Dear Alexander Stein,
>
> > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> > ---
> >
> > arch/arm/include/asm/arch-at91/at91_spi.h | 14 ++++++++++++++
> > 1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/arch-at91/at91_spi.h
> > b/arch/arm/include/asm/arch-at91/at91_spi.h index c520e89..75d4324
> > 100644
> > --- a/arch/arm/include/asm/arch-at91/at91_spi.h
> > +++ b/arch/arm/include/asm/arch-at91/at91_spi.h
> > @@ -33,6 +33,20 @@ typedef struct at91_spi {
> >
> > at91_pdc_t pdc;
> >
> > } at91_spi_t;
>
> If we touch header and driver anyway, we could get rid of the depreciated
> typedefs, to get conform to the coding style.
>
> See discussion about that 1-2 days ago :)

Ok, will do a repost after some time.

> > +#define AT91_SPI_CR_SPIEN 0x00000001
> > +#define AT91_SPI_CR_SWRST 0x00000080
> > +
> > +#define AT91_SPI_MR_MSTR 0x00000001
> > +#define AT91_SPI_MR_MODFDIS 0x00000004
> > +#define AT91_SPI_MR_PCS 0x000f0000
> > +
> > +#define AT91_SPI_SR_RXBUFF 0x00000040
> > +#define AT91_SPI_SR_SPIENS 0x00010000
> > +
> > +#define AT91_SPI_CSR_NCPHA 0x00000001
> > +#define AT91_SPI_CSR_DLYBS 0x00ff0000
> > +#define AT91_SPI_CSR_DLYBCT 0xff000000
> > +
> >
> > #ifdef CONFIG_AT91_LEGACY
>
> After that patch, do we still need LEGACY?

I'm unsure about that yet. Anyway I would prefer to remove CONFIG_AT91_LEGACY
globally at all occurrences.

Best regards,
Alexander