[U-Boot] [RFC] AT91 cleanup, was: Re: [PATCH 02/11] at91: Add USART & DBGU base address defines

Reinhard Meyer
2010-11-03T09:17:06Z

Dear Alexander Stein,

> Hello,
>
> On Tuesday 02 November 2010, 15:11:00 Reinhard Meyer wrote:
>> I leaped a bit ahead there, and did some cleanups already. Note that they
>> are not complete and are up for discussion. In order to avoid flooding the
>> list with patches, you can have a look at u-boot-atmel, at91cleanup
>> branch.
>
> At a first look it seems OK to me. Could be a good starting base.

Thank you. I see the following issues left:

Basically all legacy is gone in the drivers I use for TOP9000, except
for accesses to SMC, PMC and MATRIX.

When that is fixed arch/asm/io.h is not needed anymore.

ATMEL_ID_EMAC --> ATMEL_ID_EMAC0

CONFIG_USART_ID should be set to ATMEL_ID_USARTx to be prepared once
there are different clock domains per USART (this is not the case right
now on AT91 SoCs, but used in AVR32)

CONFIG_SYS_AT91_xxx_CLOCK could be shorter: CONFIG_SYS_xxx_CLOCK

AVR32 includes "memory-map.h", AT91 did include "hardware.h".
I changed that to "memory-map.h" and deleted hardware.h. However
including "hardware.h" seems common in other architectures. We could
go for hardware.h and adapt the AVR32 case.

Finally eliminate all LEGACY definitions in the header files.

...?

Best Regards,
Reinhard