From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] AT91 cleanup, was: Re: [PATCH 02/11] at91: Add USART & DBGU base address defines
Date: Wed, 03 Nov 2010 11:03:36 +0100 [thread overview]
Message-ID: <4CD13378.1000402@emk-elektronik.de> (raw)
In-Reply-To: <4CD12B79.5030201@gmail.com>
Andreas Bie?mann schrieb:
> Dear Reinhard Meyer,
> Am 03.11.2010 10:17, schrieb Reinhard Meyer:
>
>> ATMEL_ID_EMAC --> ATMEL_ID_EMAC0
>
> emac? isn't the sam9/avr32 mac called macb?
In AT91 its called EMAC, but uses the MACB driver. Ask ATMEL why it is named
differently :)
The value ATMEL_BASE_EMAC0 is a parameter to the MACB driver, so it does not
matter how it is named.
I try to use the component names as used in the chapter headers of the
datasheets. Where it is likely that there are multiple incarnations of the
same component in the future, I will number the only one with "0".
(There are 2x EMAC variants of the AT91 in the cooker).
>> AVR32 includes "memory-map.h", AT91 did include "hardware.h".
>> I changed that to "memory-map.h" and deleted hardware.h. However
>> including "hardware.h" seems common in other architectures. We could
>> go for hardware.h and adapt the AVR32 case.
>
> I prefer hardware.h, will change avr32 case cause i am currently working
> with avr32 board.
Do you have a ATNGW100 to check changes for that one?
Ok, I will undo the changes and remove "memory-map.h" instead.
>> Finally eliminate all LEGACY definitions in the header files.
>
> would be fine
All in at91sam9260.h have gone already.
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-11-03 10:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 8:29 [U-Boot] various at91 patches to make some boards compilable again Alexander Stein
2010-11-01 8:29 ` [U-Boot] [PATCH 01/11] at91sam9260: Replace PHYS_SDRAM with CONFIG_SYS_SDRAM_BASE Alexander Stein
2010-11-01 9:33 ` Wolfgang Denk
2010-11-01 8:29 ` [U-Boot] [PATCH 02/11] at91: Add USART & DBGU base address defines Alexander Stein
2010-11-01 10:57 ` Andreas Bießmann
2010-11-01 11:05 ` Alexander Stein
2010-11-01 11:26 ` Andreas Bießmann
2010-11-01 12:17 ` Reinhard Meyer
2010-11-02 10:42 ` Reinhard Meyer
2010-11-02 14:11 ` [U-Boot] [RFC] AT91 cleanup, was: " Reinhard Meyer
2010-11-03 7:18 ` Alexander Stein
2010-11-03 9:17 ` Reinhard Meyer
2010-11-03 9:29 ` Andreas Bießmann
2010-11-03 10:03 ` Reinhard Meyer [this message]
2010-11-03 10:25 ` Andreas Bießmann
2010-11-03 10:20 ` [U-Boot] [PATCH 1/2] [RFC] AVR32: move memory-map.h to hardware.h Andreas Bießmann
2010-11-03 15:02 ` Reinhard Meyer
2010-11-03 15:37 ` Reinhard Meyer
2010-11-05 9:15 ` [U-Boot] [PATCH v2 0/2] adopt avr32 to latest changes in u-boot-atmel/at91cleanup-rework Andreas Bießmann
2010-11-05 9:15 ` [U-Boot] [PATCH v2 1/2] avr32: rename memory-map.h -> hardware.h Andreas Bießmann
2011-04-11 8:55 ` Reinhard Meyer
2010-11-05 9:15 ` [U-Boot] [PATCH v2 2/2] avr32: fixup definitions to ATMEL_BASE_xxx Andreas Bießmann
2010-11-05 10:34 ` Reinhard Meyer
2011-04-11 8:58 ` Reinhard Meyer
2010-11-03 10:20 ` [U-Boot] [PATCH 2/2] [RFC] drivers:atmel-related: fixup include to hardware.h Andreas Bießmann
2010-11-03 15:04 ` Reinhard Meyer
2010-11-01 8:29 ` [U-Boot] [PATCH 03/11] at91: Use AT91_USART0_BASE instead of AT91_USART0 Alexander Stein
2010-11-01 10:56 ` Andreas Bießmann
2010-11-01 8:29 ` [U-Boot] [PATCH 04/11] at91sam9260ek: Convert to SoC Alexander Stein
2010-11-01 8:29 ` [U-Boot] [PATCH 05/11] at91: Fix pdc register names and add some defines Alexander Stein
2010-11-01 8:29 ` [U-Boot] [PATCH 06/11] at91: Add defines for spi SoC access Alexander Stein
2010-11-01 8:43 ` Reinhard Meyer
2010-11-01 8:52 ` Alexander Stein
2010-11-01 9:36 ` Wolfgang Denk
2010-11-01 12:31 ` Reinhard Meyer
2010-11-01 13:34 ` Alexander Stein
2010-11-04 16:07 ` Thomas Petazzoni
2010-11-01 8:29 ` [U-Boot] [PATCH 07/11] at91: Add spi base addresses Alexander Stein
2010-11-01 8:29 ` [U-Boot] [PATCH 08/11] atmel_dataflash: Update to SoC access Alexander Stein
2010-11-01 8:29 ` [U-Boot] [PATCH 09/11] at91sam9261ek: make compilable again Alexander Stein
2010-11-01 8:29 ` [U-Boot] [PATCH 10/11] at91sam9263ek: " Alexander Stein
2010-11-01 9:39 ` Wolfgang Denk
2010-11-01 8:29 ` [U-Boot] [PATCH 11/11] at91cap9adk: " Alexander Stein
2010-11-01 8:40 ` [U-Boot] various at91 patches to make some boards " Reinhard Meyer
2010-11-01 8:50 ` Alexander Stein
2010-11-01 9:30 ` Wolfgang Denk
2010-11-01 11:09 ` Andreas Bießmann
2011-01-27 19:18 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD13378.1000402@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox