[U-Boot] [PATCH] OMAP4: speed up booting on Pandaboard

Wolfgang Denk
2010-11-14T21:18:18Z

Dear Sergiy Kibrik,

In message <4CD27F08.8060309@globallogic.com> you wrote:
> Improved default config for OMAP4 Pandaboard for faster boot:
> -reduced environment size to speed up memory initialization;
> -USB TTY driver turned off;
> -tweaked blob load address to avoid image relocation (according to default uImage load address);
>
> Signed-off-by: Sergiy Kibrik <sergiy.kibrik@globallogic.com>
> ---
> include/configs/omap4_panda.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
...
> - * Total Size Environment - 256k
> + * Total Size Environment - 2k
> * Malloc - add 256k
> */
> -#define CONFIG_ENV_SIZE (256 << 10)
> +#define CONFIG_ENV_SIZE (256 << 4)

I think we had this discussion before. "256 << 4" makes no sense when
you mean 2 KiB - it requires the reader to actually perform the
calculation, which means it makes it hard for him to understand the
code. Without need. Please either write 2048, which everybody can
parse easily, or write "2 << 10" which can be parsed easily well.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"If a computer can't directly address all the RAM you can use, it's
just a toy." - anonymous comp.sys.amiga posting, non-sequitir