[U-Boot] [PATCH V4 1/2] arm926ejs: fix linker file for newer ld support

Albert ARIBAUD
2010-11-11T07:33:15Z

Le 10/11/2010 15:20, Eric Cooper a ?crit :
> On Wed, Nov 10, 2010 at 08:53:03AM +0100, Albert ARIBAUD wrote:
>> Can you make the ELF images available? I'll do the readlf/objdump
>> analysis and feed back on what I find.
>
> I've uploaded them here:
> http://www.cs.cmu.edu/~ecc/u-boot.{good,bad}
> Thanks.

I haven't found any obvious issue in the files for either good or bad
case: relocation tables are generated and correct with only types 23 and
2 records, and relocation symbols are produced and with the correct values.

the only one case I had where the code after correct relocation did not
function properly was with tx25 where the hard-coded binary size in the
config file was smaller than the actual binary size, causing only part
of the relocation table to be read back from NAND to RAM, thus skipping
a good deal of actual relocations. But here the "bad" case is smaller
than the "good" case, so even if you're using a hard-coded binary size,
*most probably* it is still ok.

Which means I cannot see why this code would not work with relocations,
all the more so since S?bastien's patches do not touch compiler or
linker flags unless I missed something. :/

However much I hate taking a "let's pretend it did not happen" stance, I
think the most effective approach here is to consider that if no-one has
issues with the ELF relocation V4 patch (Wolfgang? Alexander?) on
currently supported boards, then it only causes problems on a
not-yet-pulled-in board, so:

- V4 should be integrated now as a bug fix for existing supported boards;

- Dockstar support should be applied only after S?bastien's patches are.

Any comments?

Amicalement,
--
Albert.