* [U-Boot] [PATCH 2/4] tools: update .gitignore
2010-08-15 4:03 [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Mike Frysinger
@ 2010-08-15 4:03 ` Mike Frysinger
2010-09-12 19:39 ` Wolfgang Denk
2010-08-15 4:03 ` [U-Boot] [PATCH 3/4] unify toplevel tools targets Mike Frysinger
` (3 subsequent siblings)
4 siblings, 1 reply; 21+ messages in thread
From: Mike Frysinger @ 2010-08-15 4:03 UTC (permalink / raw)
To: u-boot
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
tools/.gitignore | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/.gitignore b/tools/.gitignore
index cb067a4..07f21a3 100644
--- a/tools/.gitignore
+++ b/tools/.gitignore
@@ -9,3 +9,8 @@
/ubsha1
/inca-swap-bytes
/*.exe
+/easylogo/easylogo
+/env/crc32.c
+/env/fw_printenv
+/gdb/gdbcont
+/gdb/gdbsend
--
1.7.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [U-Boot] [PATCH 2/4] tools: update .gitignore
2010-08-15 4:03 ` [U-Boot] [PATCH 2/4] tools: update .gitignore Mike Frysinger
@ 2010-09-12 19:39 ` Wolfgang Denk
0 siblings, 0 replies; 21+ messages in thread
From: Wolfgang Denk @ 2010-09-12 19:39 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1281845002-26525-2-git-send-email-vapier@gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> tools/.gitignore | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
Applied to "next" branch. Thanks
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is fluid ... like a river with currents, eddies, backwash.
-- Spock, "The City on the Edge of Forever", stardate 3134.0
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 3/4] unify toplevel tools targets
2010-08-15 4:03 [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Mike Frysinger
2010-08-15 4:03 ` [U-Boot] [PATCH 2/4] tools: update .gitignore Mike Frysinger
@ 2010-08-15 4:03 ` Mike Frysinger
2010-09-12 19:40 ` Wolfgang Denk
2010-08-15 4:03 ` [U-Boot] [PATCH 4/4] tools/env: use host build flags Mike Frysinger
` (2 subsequent siblings)
4 siblings, 1 reply; 21+ messages in thread
From: Mike Frysinger @ 2010-08-15 4:03 UTC (permalink / raw)
To: u-boot
Most tool subdirs do not rely on a configured tree, so move those targets
out of the config checks and unify them in the process.
Also add an easylogo target so people can easily build that.
Also add these new tool targets to the 'tools-all' target.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Makefile | 23 +++++++++++------------
1 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index 4f1cb1b..fc328df 100644
--- a/Makefile
+++ b/Makefile
@@ -397,14 +397,8 @@ $(TIMESTAMP_FILE):
@LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@
@LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@
-gdbtools:
- $(MAKE) -C tools/gdb all || exit 1
-
updater:
- $(MAKE) -C tools/updater all || exit 1
-
-env:
- $(MAKE) -C tools/env all MTD_VERSION=${MTD_VERSION} || exit 1
+ $(MAKE) -C tools/updater all
# Explicitly make _depend in subdirs containing multiple targets to prevent
# parallel sub-makes creating .depend files simultaneously.
@@ -459,17 +453,22 @@ $(obj)include/autoconf.mk: $(obj)include/config.h
else # !config.mk
all $(obj)u-boot.hex $(obj)u-boot.srec $(obj)u-boot.bin \
$(obj)u-boot.img $(obj)u-boot.dis $(obj)u-boot \
-$(filter-out tools,$(SUBDIRS)) $(TIMESTAMP_FILE) $(VERSION_FILE) gdbtools \
-updater env depend dep tags ctags etags cscope $(obj)System.map:
+$(filter-out tools,$(SUBDIRS)) $(TIMESTAMP_FILE) $(VERSION_FILE) \
+updater depend dep tags ctags etags cscope $(obj)System.map:
@echo "System not configured - see README" >&2
@ exit 1
tools:
- $(MAKE) -C tools
-tools-all:
- $(MAKE) -C tools HOST_TOOLS_ALL=y
+ $(MAKE) -C $@ all
endif # config.mk
+easylogo env gdb:
+ $(MAKE) -C tools/$@ all MTD_VERSION=${MTD_VERSION}
+gdbtools: gdb
+
+tools-all: easylogo env gdb
+ $(MAKE) -C tools HOST_TOOLS_ALL=y
+
.PHONY : CHANGELOG
CHANGELOG:
git log --no-merges U-Boot-1_1_5.. | \
--
1.7.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [U-Boot] [PATCH 3/4] unify toplevel tools targets
2010-08-15 4:03 ` [U-Boot] [PATCH 3/4] unify toplevel tools targets Mike Frysinger
@ 2010-09-12 19:40 ` Wolfgang Denk
0 siblings, 0 replies; 21+ messages in thread
From: Wolfgang Denk @ 2010-09-12 19:40 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1281845002-26525-3-git-send-email-vapier@gentoo.org> you wrote:
> Most tool subdirs do not rely on a configured tree, so move those targets
> out of the config checks and unify them in the process.
>
> Also add an easylogo target so people can easily build that.
>
> Also add these new tool targets to the 'tools-all' target.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> Makefile | 23 +++++++++++------------
> 1 files changed, 11 insertions(+), 12 deletions(-)
Applied to "next" branch. Thanks
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: kernel trap (ignored)
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-08-15 4:03 [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Mike Frysinger
2010-08-15 4:03 ` [U-Boot] [PATCH 2/4] tools: update .gitignore Mike Frysinger
2010-08-15 4:03 ` [U-Boot] [PATCH 3/4] unify toplevel tools targets Mike Frysinger
@ 2010-08-15 4:03 ` Mike Frysinger
2010-09-12 19:41 ` Wolfgang Denk
2010-09-12 19:39 ` [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Wolfgang Denk
2010-09-12 20:05 ` Wolfgang Denk
4 siblings, 1 reply; 21+ messages in thread
From: Mike Frysinger @ 2010-08-15 4:03 UTC (permalink / raw)
To: u-boot
Convert the tools/env/Makefile to use the same host tool syntax as the
other tool subdirs.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
tools/env/Makefile | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/env/Makefile b/tools/env/Makefile
index 2df631e..f893040 100644
--- a/tools/env/Makefile
+++ b/tools/env/Makefile
@@ -26,16 +26,16 @@ include $(TOPDIR)/config.mk
SRCS := $(obj)crc32.c fw_env.c fw_env_main.c
HEADERS := fw_env.h
-CPPFLAGS := -Wall -DUSE_HOSTCC -I$(SRCTREE)/include
+HOSTCFLAGS += -Wall -DUSE_HOSTCC -I$(SRCTREE)/include
ifeq ($(MTD_VERSION),old)
-CPPFLAGS += -DMTD_OLD
+HOSTCFLAGS += -DMTD_OLD
endif
all: $(obj)fw_printenv
$(obj)fw_printenv: $(SRCS) $(HEADERS)
- $(CROSS_COMPILE)gcc $(CPPFLAGS) $(SRCS) -o $(obj)fw_printenv
+ $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $(SRCS)
clean:
rm -f $(obj)fw_printenv $(obj)crc32.c
--
1.7.2
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-08-15 4:03 ` [U-Boot] [PATCH 4/4] tools/env: use host build flags Mike Frysinger
@ 2010-09-12 19:41 ` Wolfgang Denk
2010-11-08 18:15 ` Detlev Zundel
0 siblings, 1 reply; 21+ messages in thread
From: Wolfgang Denk @ 2010-09-12 19:41 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1281845002-26525-4-git-send-email-vapier@gentoo.org> you wrote:
> Convert the tools/env/Makefile to use the same host tool syntax as the
> other tool subdirs.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> tools/env/Makefile | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Applied to "next" branch. Thanks
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"UNIX was not designed to stop you from doing stupid things, because
that would also stop you from doing clever things." - Doug Gwyn
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-09-12 19:41 ` Wolfgang Denk
@ 2010-11-08 18:15 ` Detlev Zundel
2010-11-08 23:15 ` Wolfgang Denk
2010-11-10 9:19 ` Mike Frysinger
0 siblings, 2 replies; 21+ messages in thread
From: Detlev Zundel @ 2010-11-08 18:15 UTC (permalink / raw)
To: u-boot
Hi,
> Dear Mike Frysinger,
>
> In message <1281845002-26525-4-git-send-email-vapier@gentoo.org> you wrote:
>> Convert the tools/env/Makefile to use the same host tool syntax as the
>> other tool subdirs.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> ---
>> tools/env/Makefile | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Applied to "next" branch. Thanks
It just occurred to me that this will no longer cross compile the fw_env
tool - effectively rendering the tool useless for me.
Mike, what _exactly_ was the reason to drop cross compilation?
Cheers
Detlev
--
By all means let's be open-minded, but not so open-minded that our
brains drop out.
-- Richard Dawkins
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 21+ messages in thread* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-08 18:15 ` Detlev Zundel
@ 2010-11-08 23:15 ` Wolfgang Denk
2010-11-09 0:01 ` Steve Sakoman
2010-11-10 9:19 ` Mike Frysinger
1 sibling, 1 reply; 21+ messages in thread
From: Wolfgang Denk @ 2010-11-08 23:15 UTC (permalink / raw)
To: u-boot
Dear Detlev Zundel,
In message <m2k4knd6lx.fsf@ohwell.denx.de> you wrote:
>
> > Applied to "next" branch. Thanks
>
> It just occurred to me that this will no longer cross compile the fw_env
> tool - effectively rendering the tool useless for me.
Argh... Indeed, that's broken.
> Mike, what _exactly_ was the reason to drop cross compilation?
Mike, I think we should revert that commit?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is nothing new under the sun, but there are lots of old things
we don't know yet." - Ambrose Bierce
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-08 23:15 ` Wolfgang Denk
@ 2010-11-09 0:01 ` Steve Sakoman
2010-11-09 9:19 ` Daniel Hobi
0 siblings, 1 reply; 21+ messages in thread
From: Steve Sakoman @ 2010-11-09 0:01 UTC (permalink / raw)
To: u-boot
On Mon, Nov 8, 2010 at 3:15 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Detlev Zundel,
>
> In message <m2k4knd6lx.fsf@ohwell.denx.de> you wrote:
>>
>> > Applied to "next" branch. Thanks
>>
>> It just occurred to me that this will no longer cross compile the fw_env
>> tool - effectively rendering the tool useless for me.
>
> Argh... Indeed, that's broken.
>
>> Mike, what _exactly_ was the reason to drop cross compilation?
>
> Mike, I think we should revert that commit?
I ran into this issue this week too.
Reverting is one option. I also tried Daniel Hobi's patch "tools/env:
cleanup host build flags" and that worked for me.
Steve
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-09 0:01 ` Steve Sakoman
@ 2010-11-09 9:19 ` Daniel Hobi
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Hobi @ 2010-11-09 9:19 UTC (permalink / raw)
To: u-boot
Hi Steve,
On 09.11.2010 01:01, Steve Sakoman wrote:
> On Mon, Nov 8, 2010 at 3:15 PM, Wolfgang Denk <wd@denx.de> wrote:
>> In message <m2k4knd6lx.fsf@ohwell.denx.de> you wrote:
>>> It just occurred to me that this will no longer cross compile the fw_env
>>> tool - effectively rendering the tool useless for me.
>>
>> Argh... Indeed, that's broken.
>
> I ran into this issue this week too.
>
> Reverting is one option. I also tried Daniel Hobi's patch "tools/env:
> cleanup host build flags" and that worked for me.
You are refering to this WIP patch:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/86236
It makes the fw_env tool Makefile similar to the imls Makefile and
solves the errno inclusion problem reported by Detlev.
I still think we need a third set of CC, CFLAGS, SRCS, etc defines for
compiling tools running on the target. However, we probably can default
to the combination CC+HOSTCFLAGS for most platforms.
Best regards,
Daniel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-08 18:15 ` Detlev Zundel
2010-11-08 23:15 ` Wolfgang Denk
@ 2010-11-10 9:19 ` Mike Frysinger
2010-11-10 19:54 ` Wolfgang Denk
1 sibling, 1 reply; 21+ messages in thread
From: Mike Frysinger @ 2010-11-10 9:19 UTC (permalink / raw)
To: u-boot
On Monday, November 08, 2010 13:15:38 Detlev Zundel wrote:
> > Mike Frysinger wrote:
> >> Convert the tools/env/Makefile to use the same host tool syntax as the
> >> other tool subdirs.
> >
> > Applied to "next" branch. Thanks
>
> It just occurred to me that this will no longer cross compile the fw_env
> tool - effectively rendering the tool useless for me.
>
> Mike, what _exactly_ was the reason to drop cross compilation?
nothing was "dropped". you need to set your HOSTCC correctly for the host on
which you want tools to compile.
this is like arguing that none of the tools in tools/Makefile cross-compile.
they do. i simply fixed tools/env/Makefile to operate the same.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101110/4446ffd3/attachment.pgp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-10 9:19 ` Mike Frysinger
@ 2010-11-10 19:54 ` Wolfgang Denk
2010-11-10 22:11 ` Mike Frysinger
0 siblings, 1 reply; 21+ messages in thread
From: Wolfgang Denk @ 2010-11-10 19:54 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <201011100419.10315.vapier@gentoo.org> you wrote:
>
> > Mike, what _exactly_ was the reason to drop cross compilation?
>
> nothing was "dropped". you need to set your HOSTCC correctly for the host on
> which you want tools to compile.
But it is WRONG to use HOSTCC for fw_* - these are _target_ tools, and
they need to be CROSS compiled.
> this is like arguing that none of the tools in tools/Makefile cross-compile.
> they do. i simply fixed tools/env/Makefile to operate the same.
Seems this was not a fix, but introduced an error. Dp you agree to
revert that commit?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The more we disagree, the more chance there is that at least one of
us is right.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-10 19:54 ` Wolfgang Denk
@ 2010-11-10 22:11 ` Mike Frysinger
2010-11-10 22:29 ` Wolfgang Denk
0 siblings, 1 reply; 21+ messages in thread
From: Mike Frysinger @ 2010-11-10 22:11 UTC (permalink / raw)
To: u-boot
On Wednesday, November 10, 2010 14:54:17 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > Mike, what _exactly_ was the reason to drop cross compilation?
> >
> > nothing was "dropped". you need to set your HOSTCC correctly for the
> > host on which you want tools to compile.
>
> But it is WRONG to use HOSTCC for fw_* - these are _target_ tools, and
> they need to be CROSS compiled.
so do what i said -- set the HOSTCC to the host you want the tools to run on.
this will work for *all* tools instead of arbitrarily picking some to use
HOSTCC while picking others to use CROSS.
> > this is like arguing that none of the tools in tools/Makefile
> > cross-compile. they do. i simply fixed tools/env/Makefile to operate
> > the same.
>
> Seems this was not a fix, but introduced an error. Dp you agree to
> revert that commit?
of course i disagree. this change is a fix in my mind.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101110/653fc75a/attachment.pgp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-10 22:11 ` Mike Frysinger
@ 2010-11-10 22:29 ` Wolfgang Denk
2010-11-10 22:55 ` Mike Frysinger
0 siblings, 1 reply; 21+ messages in thread
From: Wolfgang Denk @ 2010-11-10 22:29 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <201011101711.17574.vapier@gentoo.org> you wrote:
>
> so do what i said -- set the HOSTCC to the host you want the tools to run on.
> this will work for *all* tools instead of arbitrarily picking some to use
> HOSTCC while picking others to use CROSS.
Why are you so ignorant?
There are tools that are supposed to run on the build host (like
mkimage or gen_eth_addr), and there are tools that are supposed to
run on the target (like fw_*).
Your "one size fits all" approach is broken.
> > Seems this was not a fix, but introduced an error. Dp you agree to
> > revert that commit?
>
> of course i disagree. this change is a fix in my mind.
Please reconsider. This has been working for nearly a decade, and now
it's broken. I want to see this fixed. If needed, by reverting the
commit that broke it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Programmer's Lament: (Shakespeare, Macbeth, Act I, Scene vii)
"That we but teach bloody instructions,
which, being taught, return to plague the inventor..."
^ permalink raw reply [flat|nested] 21+ messages in thread* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-10 22:29 ` Wolfgang Denk
@ 2010-11-10 22:55 ` Mike Frysinger
2010-11-14 21:59 ` Wolfgang Denk
0 siblings, 1 reply; 21+ messages in thread
From: Mike Frysinger @ 2010-11-10 22:55 UTC (permalink / raw)
To: u-boot
On Wednesday, November 10, 2010 17:29:52 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > so do what i said -- set the HOSTCC to the host you want the tools to run
> > on. this will work for *all* tools instead of arbitrarily picking some
> > to use HOSTCC while picking others to use CROSS.
>
> Why are you so ignorant?
cut the crap
> There are tools that are supposed to run on the build host (like
> mkimage or gen_eth_addr), and there are tools that are supposed to
> run on the target (like fw_*).
you're assuming too much here as well. i need to support cross-compiling all
the tools for when the build==host==target and build!=host==target and
build!=host!=target. this is the stuff i hit every day with package managers
and distro setups.
> > > Seems this was not a fix, but introduced an error. Dp you agree to
> > > revert that commit?
> >
> > of course i disagree. this change is a fix in my mind.
>
> Please reconsider. This has been working for nearly a decade, and now
> it's broken. I want to see this fixed. If needed, by reverting the
> commit that broke it.
it's been working for your specific use cases. it hasnt been working without
pains for everyone.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101110/1a43ac06/attachment.pgp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-10 22:55 ` Mike Frysinger
@ 2010-11-14 21:59 ` Wolfgang Denk
2010-11-15 11:35 ` Mike Frysinger
0 siblings, 1 reply; 21+ messages in thread
From: Wolfgang Denk @ 2010-11-14 21:59 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <201011101755.54287.vapier@gentoo.org> you wrote:
>
> > > > Seems this was not a fix, but introduced an error. Dp you agree to
> > > > revert that commit?
> > >
> > > of course i disagree. this change is a fix in my mind.
> >
> > Please reconsider. This has been working for nearly a decade, and now
> > it's broken. I want to see this fixed. If needed, by reverting the
> > commit that broke it.
>
> it's been working for your specific use cases. it hasnt been working without
> pains for everyone.
I agree you have a point.
But it is a change in behaviour, and what it makes worse it that it's
an undocumented one. Users who have been doing the same thing for a
decade suddenly find their old scripts are not working any more, and
there it even a hint of what they do now.
If we decide that such a change makes sense, then it must be
explained and documented properly.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In English, every word can be verbed. Would that it were so in our
programming languages.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 4/4] tools/env: use host build flags
2010-11-14 21:59 ` Wolfgang Denk
@ 2010-11-15 11:35 ` Mike Frysinger
0 siblings, 0 replies; 21+ messages in thread
From: Mike Frysinger @ 2010-11-15 11:35 UTC (permalink / raw)
To: u-boot
On Sunday, November 14, 2010 16:59:33 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > > > Seems this was not a fix, but introduced an error. Dp you agree to
> > > > > revert that commit?
> > > >
> > > > of course i disagree. this change is a fix in my mind.
> > >
> > > Please reconsider. This has been working for nearly a decade, and now
> > > it's broken. I want to see this fixed. If needed, by reverting the
> > > commit that broke it.
> >
> > it's been working for your specific use cases. it hasnt been working
> > without pains for everyone.
>
> I agree you have a point.
>
> But it is a change in behaviour, and what it makes worse it that it's
> an undocumented one. Users who have been doing the same thing for a
> decade suddenly find their old scripts are not working any more, and
> there it even a hint of what they do now.
>
> If we decide that such a change makes sense, then it must be
> explained and documented properly.
i guess i can try harder to goad Daniel into getting his work going
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101115/ec96b446/attachment.pgp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target
2010-08-15 4:03 [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Mike Frysinger
` (2 preceding siblings ...)
2010-08-15 4:03 ` [U-Boot] [PATCH 4/4] tools/env: use host build flags Mike Frysinger
@ 2010-09-12 19:39 ` Wolfgang Denk
2010-09-12 19:44 ` Mike Frysinger
2010-09-12 20:05 ` Wolfgang Denk
4 siblings, 1 reply; 21+ messages in thread
From: Wolfgang Denk @ 2010-09-12 19:39 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1281845002-26525-1-git-send-email-vapier@gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> tools/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 749d994..ea271bf 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -41,6 +41,7 @@ include $(TOPDIR)/config.mk
> # Enable all the config-independent tools
> ifneq ($(HOST_TOOLS_ALL),)
> CONFIG_LCD_LOGO = y
> +CONFIG_CMD_LOADS = y
> CONFIG_CMD_NET = y
> CONFIG_INCA_IP = y
> CONFIG_NETCONSOLE = y
Do we really need this? Only very few people will ever need the
img2srec tool, so why build it for everybody?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You'll learn something about men and women -- the way they're
supposed to be. Caring for each other, being happy with each other,
being good to each other. That's what we call love. You'll like that
a lot.
-- Kirk, "The Apple", stardate 3715.6
^ permalink raw reply [flat|nested] 21+ messages in thread* [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target
2010-09-12 19:39 ` [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Wolfgang Denk
@ 2010-09-12 19:44 ` Mike Frysinger
0 siblings, 0 replies; 21+ messages in thread
From: Mike Frysinger @ 2010-09-12 19:44 UTC (permalink / raw)
To: u-boot
On Sunday, September 12, 2010 15:39:06 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > diff --git a/tools/Makefile b/tools/Makefile
> > index 749d994..ea271bf 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -41,6 +41,7 @@ include $(TOPDIR)/config.mk
> >
> > # Enable all the config-independent tools
> > ifneq ($(HOST_TOOLS_ALL),)
> > CONFIG_LCD_LOGO = y
> >
> > +CONFIG_CMD_LOADS = y
> >
> > CONFIG_CMD_NET = y
> > CONFIG_INCA_IP = y
> > CONFIG_NETCONSOLE = y
>
> Do we really need this? Only very few people will ever need the
> img2srec tool, so why build it for everybody?
it is only built when people do `make tools-all`, not `make tools`, and in
this case, yes, i think we should be building it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100912/8da55728/attachment.pgp
^ permalink raw reply [flat|nested] 21+ messages in thread
* [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target
2010-08-15 4:03 [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Mike Frysinger
` (3 preceding siblings ...)
2010-09-12 19:39 ` [U-Boot] [PATCH 1/4] tools: enable img2srec for "all" target Wolfgang Denk
@ 2010-09-12 20:05 ` Wolfgang Denk
4 siblings, 0 replies; 21+ messages in thread
From: Wolfgang Denk @ 2010-09-12 20:05 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1281845002-26525-1-git-send-email-vapier@gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> tools/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Applied to "next" after editing the subject to say "tools-all" instead
of "all" (which misled me).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I don't care if you *ARE* on a bondage-and-discipline post-technical
system pawned off by the nation's largest oughta-be-illegal monopoly
who cannot escape the sins of their forefathers -- namely, using the
wrong slash for directories when the C language and its brethren use
it for something else that's very important.
-- Tom Christiansen in <55oabg$1j1$1@csnews.cs.colorado.edu>
^ permalink raw reply [flat|nested] 21+ messages in thread