[U-Boot] [PATCH] powerpc/85xx: compare actual device addresses with the device tree

Wolfgang Denk
2010-11-16T23:10:35Z

Dear Timur Tabi,

In message <4CE302A5.8070608@freescale.com> you wrote:
>
> >> Would "fdt verify" be a good place?
> >
> > Yes, sounds good to me.
>
> There is one problem -- a lot of the code is 85xx-specific. I'm not sure how to
> reasonably make this feature available to all fdt-capable architectures. Would
> you be okay with I enclosed it in an #ifdef CONFIG_MPC85xx, like this:

No, I don't like this. The parts that are not specific to 85xx should
be available to all, and CPU specific (and eventually board specific?)
parts should be possible by calling into respective functions (which
might, for example, have weak dummy implementations).

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am pleased to see that we have differences. May we together become
greater than the sum of both of us.
-- Surak of Vulcan, "The Savage Curtain", stardate 5906.4