[U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f

Wolfgang Denk
2010-11-12T08:50:13Z

Dear Reinhard Meyer,

In message <4CDCE769.8080209@emk-elektronik.de> you wrote:
>
> Is bootflag ever used? If not, why not change the parameter to
> give the gd address to board_init_f?

No, bootflag is never used and could / should be removed.

Passing gd as parameter makes no sense, thoug, as it's global data and
we reserve a register to store it's address, so it can always be used
with minimal overhead.

> One further thought, why not init the reserved register in assembly and
> remove the gd relevant code in C? But that bears some risk if the register
> is changed and the assembly is forgotten to adapt..

We try to do as much as pssible in C, and only what really cannot be
avoided in assembly.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The last thing one knows in constructing a work is what to put first.
- Blaise Pascal