From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Fri, 12 Nov 2010 20:47:11 +1100 Subject: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f In-Reply-To: <20101112085013.62415193@gemini.denx.de> References: <1289544835-24425-1-git-send-email-hs@denx.de> <4CDCE769.8080209@emk-elektronik.de> <20101112085013.62415193@gemini.denx.de> Message-ID: <4CDD0D1F.7010805@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/11/10 19:50, Wolfgang Denk wrote: > Dear Reinhard Meyer, > > In message <4CDCE769.8080209@emk-elektronik.de> you wrote: >> >> Is bootflag ever used? If not, why not change the parameter to >> give the gd address to board_init_f? > > No, bootflag is never used and could / should be removed. > > Passing gd as parameter makes no sense, thoug, as it's global data and > we reserve a register to store it's address, so it can always be used > with minimal overhead. Which is a really nice idea if you have a register to spare. Unfortunately, x86 does not have this luxury, and the only way I can get gd (and as a consequence upper memory bound for relocation) is to allocate it in assembler and pass to C as a function argument Regards, Graeme