public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Commit ecee9... (Program net device MAC addresses after initializing) breakage
Date: Sat, 13 Nov 2010 12:51:12 +1100	[thread overview]
Message-ID: <4CDDEF10.1030908@gmail.com> (raw)
In-Reply-To: <201011122011.43105.vapier@gentoo.org>

On 13/11/10 12:11, Mike Frysinger wrote:
> On Friday, November 12, 2010 05:55:55 Graeme Russ wrote:
>> On 10/11/10 14:36, Mike Frysinger wrote:
>>> On Saturday, November 06, 2010 18:13:08 Graeme Russ wrote:
>>>> I saw discussion a little while ago regarding implementing a version of
>>>> malloc that returns cleared memory - did this gain any traction?
>>>
>>> i dont think anyone posted a patch.  it would make sense though to
>>> generalize the zalloc() code since some places are already doing it.
>>
>> Actually, I think we should be using calloc() more than we are
> 
> if we want to define zalloc() to calloc(), then sure.  but forcing people to 
> use calloc() with a size=1 is silly.  the API is not nearly as obvious to 
> passing observers as zalloc().

Hmm, U-Boot has a zalloc in lib/gunzip.c which does not zero memory

void *zalloc(void *x, unsigned items, unsigned size)
{
	void *p;

	size *= items;
	size = (size + ZALLOC_ALIGNMENT - 1) & ~(ZALLOC_ALIGNMENT - 1);

	p = malloc (size);

	return (p);
}

and mtd has kzalloc defined thus:

#define kzalloc(size, flags)	calloc(size, 1)

So there is some confusion surrounding 'zalloc' anyway ;)

Regards,

Graeme

  reply	other threads:[~2010-11-13  1:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 22:13 [U-Boot] Commit ecee9... (Program net device MAC addresses after initializing) breakage Graeme Russ
2010-11-08 14:38 ` Kumar Gala
2010-11-10  3:36 ` Mike Frysinger
2010-11-12 10:55   ` Graeme Russ
2010-11-13  1:11     ` Mike Frysinger
2010-11-13  1:51       ` Graeme Russ [this message]
2010-11-13  2:20         ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDDEF10.1030908@gmail.com \
    --to=graeme.russ@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox