public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] FSL_ESDHC: Make the base address configurable at runtime
Date: Sun, 14 Nov 2010 18:08:58 +0100	[thread overview]
Message-ID: <4CE017AA.808@denx.de> (raw)
In-Reply-To: <201011141801.48221.marek.vasut@gmail.com>

On 11/14/2010 06:01 PM, Marek Vasut wrote:

> Hi Wolfgang,
> 
> it means Stefano explained to me he already tried pushing in such a patch and 
> the patch was rejected. Therefore, I assume you should ignore this patch.

To complete the explanation: there is already a way to make address
configurable and we do not need to change fsl_esdhc_mmc_init.

The fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg) was added
to the driver when I pushed the MX51 stuff, allowing us to set up the
base address, Not only, the struct fsl_esdhc_cfg could be extended in
the future, if we will need it (but not at the moment, as I know).

This way is already used by the mx51evk (both SDHC controller are
supported) and by the vision2 (only one SDHC controller is supported).

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2010-11-14 17:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 16:01 [U-Boot] [PATCH] FSL_ESDHC: Make the base address configurable at runtime Marek Vasut
2010-11-14 16:35 ` Marek Vasut
2010-11-14 16:59   ` Wolfgang Denk
2010-11-14 17:01     ` Marek Vasut
2010-11-14 17:08       ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE017AA.808@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox