From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] previous two e-mails are RFC/demonstration!
Date: Sun, 14 Nov 2010 21:24:37 +0100 [thread overview]
Message-ID: <4CE04585.807@free.fr> (raw)
In-Reply-To: <4CE03BA0.7010800@emk-elektronik.de>
Le 14/11/2010 20:42, Reinhard Meyer a ?crit :
> 1. I am quite sure that in arm/lib/board.c
> __asm__ __volatile__("": : :"memory");
> was never needed and definitely is not needed anymore.
> Can anyone shed some light on why this was added?
> Probably just copied from other architectures where some trickery
> around gd was done?
This kind of barrier is needed when the compiler might reorder code
without seeing a dependency (I met such a case in the Marvell egiga
driver code). Here, I don't see the reason offhand.
> 4. start.S need just set the SP to CONFIG_SYS_INIT_SP_ADDR,
> if one wants to be over-cautious extra alignment *can* be done.
Currently start.S sets the stack twice, once before calling
board_init_f, and once in relocate_code. Are you suggesting we remove
the second sp setting?
> Best Regards,
> Reinhard
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-11-14 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 16:00 [U-Boot] previous two e-mails are RFC/demonstration! Reinhard Meyer
2010-11-14 16:23 ` Wolfgang Denk
2010-11-14 19:42 ` Reinhard Meyer
2010-11-14 20:24 ` Albert ARIBAUD [this message]
2010-11-14 20:33 ` Reinhard Meyer
2010-11-14 20:44 ` Wolfgang Denk
2010-11-14 20:59 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE04585.807@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox