From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 14 Nov 2010 21:24:37 +0100 Subject: [U-Boot] previous two e-mails are RFC/demonstration! In-Reply-To: <4CE03BA0.7010800@emk-elektronik.de> References: <4CE00793.8070501@emk-elektronik.de> <20101114162340.9766714EA7E@gemini.denx.de> <4CE03BA0.7010800@emk-elektronik.de> Message-ID: <4CE04585.807@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 14/11/2010 20:42, Reinhard Meyer a ?crit : > 1. I am quite sure that in arm/lib/board.c > __asm__ __volatile__("": : :"memory"); > was never needed and definitely is not needed anymore. > Can anyone shed some light on why this was added? > Probably just copied from other architectures where some trickery > around gd was done? This kind of barrier is needed when the compiler might reorder code without seeing a dependency (I met such a case in the Marvell egiga driver code). Here, I don't see the reason offhand. > 4. start.S need just set the SP to CONFIG_SYS_INIT_SP_ADDR, > if one wants to be over-cautious extra alignment *can* be done. Currently start.S sets the stack twice, once before calling board_init_f, and once in relocate_code. Are you suggesting we remove the second sp setting? > Best Regards, > Reinhard Amicalement, -- Albert.