public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sergiy Kibrik <sergiy.kibrik@globallogic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP4: speed up booting on Pandaboard
Date: Mon, 15 Nov 2010 12:26:30 +0200	[thread overview]
Message-ID: <4CE10AD6.3010305@globallogic.com> (raw)
In-Reply-To: <20101114211818.2FD5D134F54@gemini.denx.de>

On 11/14/2010 11:18 PM, Wolfgang Denk wrote:
> Dear Sergiy Kibrik,
> 
> In message <4CD27F08.8060309@globallogic.com> you wrote:
>> Improved default config for OMAP4 Pandaboard for faster boot:
>> 	-reduced environment size to speed up memory initialization;
>> 	-USB TTY driver turned off;
>> 	-tweaked blob load address to avoid image relocation (according to default uImage load address);
>>
>> Signed-off-by: Sergiy Kibrik <sergiy.kibrik@globallogic.com>
>> ---
>>  include/configs/omap4_panda.h |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
> ...
>> - * Total Size Environment - 256k
>> + * Total Size Environment - 2k
>>   * Malloc - add 256k
>>   */
>> -#define CONFIG_ENV_SIZE			(256 << 10)
>> +#define CONFIG_ENV_SIZE			(256 << 4)
> 
> I think we had this discussion before. "256 << 4" makes no sense when
> you mean 2 KiB - it requires the reader to actually perform the
> calculation, which means it makes it hard for him to understand the
> code. Without need. Please either write 2048, which everybody can
> parse easily, or write "2 << 10" which can be parsed easily well.
> 

I've considered advices you gave me in this thread:
http://marc.info/?t=128897628400001&r=1&w=2

and resubmitted the patch
http://marc.info/?l=u-boot&m=128922349828119&w=2

Haven't you received that?

-regards,
Sergey

      reply	other threads:[~2010-11-15 10:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04  9:38 [U-Boot] [PATCH] OMAP4: speed up booting on Pandaboard Sergiy Kibrik
2010-11-04 15:46 ` Nishanth Menon
2010-11-05 12:35   ` Sergiy Kibrik
2010-11-05 13:12     ` Nishanth Menon
2010-11-05 14:44       ` Sergiy Kibrik
2010-11-05 15:49         ` Nishanth Menon
2010-11-05 16:55           ` Sergiy Kibrik
     [not found] ` <AANLkTimzqVd6NqJ-s6-2Vw1gNbiOgJKHjNs-teTz5wFY@mail.gmail.com>
2010-11-04 18:10   ` [U-Boot] Fwd: " Steve Sakoman
2010-11-14 21:18 ` [U-Boot] " Wolfgang Denk
2010-11-15 10:26   ` Sergiy Kibrik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE10AD6.3010305@globallogic.com \
    --to=sergiy.kibrik@globallogic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox