From: Andre Schwarz <andre.schwarz@matrix-vision.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] don't touch non-existent EHCI regs on MPC837x.
Date: Mon, 15 Nov 2010 16:14:06 +0100 [thread overview]
Message-ID: <4CE14E3E.7060208@matrix-vision.de> (raw)
In-Reply-To: <01B47185-4A57-498D-9F4E-694A38DFDB4D@kernel.crashing.org>
Kumar,
>> Signed-off-by: Andre Schwarz<andre.schwarz@matrix-vision.de>
>> ---
>> arch/powerpc/cpu/mpc83xx/cpu_init.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
> This doesn't seem quite right, the MPC837x has USB controllers.
>
> - k
>
yes, it has - and it is working fine.
But USB register range 0x00-0xff is reserved and hangs the CPU.
With this patch USB is working fine on at least MPC8377.
>> diff --git a/arch/powerpc/cpu/mpc83xx/cpu_init.c b/arch/powerpc/cpu/mpc83xx/cpu_init.c
>> index 7a1cae7..cfead18 100644
>> --- a/arch/powerpc/cpu/mpc83xx/cpu_init.c
>> +++ b/arch/powerpc/cpu/mpc83xx/cpu_init.c
>> @@ -327,7 +327,7 @@ void cpu_init_f (volatile immap_t * im)
>> im->gpio[1].dir = CONFIG_SYS_GPIO2_DIR;
>> #endif
>> #ifdef CONFIG_USB_EHCI_FSL
>> -#ifndef CONFIG_MPC834x
>> +#if !defined(CONFIG_MPC834x)&& !defined(CONFIG_MPC837x)
>> uint32_t temp;
>> struct usb_ehci *ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB_ADDR;
>>
>> --
>> 1.7.0.4
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
Regards,
Andr?
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
next prev parent reply other threads:[~2010-11-15 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 14:53 [U-Boot] [PATCH] don't touch non-existent EHCI regs on MPC837x Andre Schwarz
2010-11-15 15:07 ` Kumar Gala
2010-11-15 15:14 ` Andre Schwarz [this message]
2010-11-15 15:29 ` Wolfgang Denk
2010-11-15 15:52 ` Andre Schwarz
2010-11-15 16:16 ` Wolfgang Denk
2010-11-15 16:21 ` Andre Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE14E3E.7060208@matrix-vision.de \
--to=andre.schwarz@matrix-vision.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox