From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Schwarz Date: Mon, 15 Nov 2010 16:52:12 +0100 Subject: [U-Boot] [PATCH] don't touch non-existent EHCI regs on MPC837x. In-Reply-To: <20101115152950.30A7B134FEF@gemini.denx.de> References: <1289832783-18402-1-git-send-email-andre.schwarz@matrix-vision.de> <01B47185-4A57-498D-9F4E-694A38DFDB4D@kernel.crashing.org> <4CE14E3E.7060208@matrix-vision.de> <20101115152950.30A7B134FEF@gemini.denx.de> Message-ID: <4CE1572C.6080804@matrix-vision.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang, > Dear Andre Schwarz, > > In message<4CE14E3E.7060208@matrix-vision.de> you wrote: > >> >>> This doesn't seem quite right, the MPC837x has USB controllers. >>> >> yes, it has - and it is working fine. >> But USB register range 0x00-0xff is reserved and hangs the CPU. >> >> With this patch USB is working fine on at least MPC8377. >> > Then the commit message should make this clear. At the moment it is > pretty much misleading. > I didn't add this #ifdef but extended it to not only match 834x but also 837x. All I see is that the ifdef'ed code accesses registers which are explicitely reserved on MPC834x and at least MPC837x. What would be an appropriate commit message from your point of view ? Regards, Andr? MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner