From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 16 Nov 2010 18:16:26 +0100 Subject: [U-Boot] [PATCH V4][NEXT] Davinci: add support for the ea20 board In-Reply-To: References: <1289638030-6838-1-git-send-email-sbabic@denx.de> <1289902019-12212-1-git-send-email-sbabic@denx.de> Message-ID: <4CE2BC6A.50406@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/16/2010 04:44 PM, Ben Gardiner wrote: > On Tue, Nov 16, 2010 at 5:06 AM, Stefano Babic wrote: >> This board uses the OMAP-L138 SOM stacked on a >> custom baseboard. It supports SPI Flash, Ethernet >> with RMII. Hi Ben, > If this patch is based on the da850evm RMII support as previous > version indicated then could this function prototype and the > implementation below be wrapped in #if defined(CONFIG_DRIVER_TI_EMAC) > and the corresponding declaration and implementations added to > board/davinci/da8xxevm/common.{h,c} in the RMII patch be removed to > minimize duplicate code? Sorry, In my previous e-mail I misunderstood what you meant. You are right, we have to drop the function from da8xxevm/common.{h,c}, or we duplicate the code. I will send a patch for that. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================