From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Tue, 16 Nov 2010 16:16:05 -0600
Subject: [U-Boot] [PATCH] powerpc/85xx: compare actual device addresses
 with the device tree
In-Reply-To: <20101110211312.EFBEAB195@gemini.denx.de>
References: <1289343709-11793-1-git-send-email-timur@freescale.com>
	<20101110195113.3A7871522C0@gemini.denx.de>
	<4CDAFC37.40309@freescale.com>
	<20101110203451.550DD1522C0@gemini.denx.de>
	<4CDB0686.300@freescale.com>
	<20101110211312.EFBEAB195@gemini.denx.de>
Message-ID: <4CE302A5.8070608@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> 
>> > If we agree that this is adebug help, then please provide a separate
>> > command to perform this operation. Make this command optional (feel
>> > free to add it to the default list, but it must be possible to disable
>> > it if wanted). Then users who want this feature can add it to their
>> > boot command sequence, and others, who are interested in fast boot
>> > times can omit it.
>>
>> Would "fdt verify" be a good place?
> 
> Yes, sounds good to me.

There is one problem -- a lot of the code is 85xx-specific.  I'm not sure how to
reasonably make this feature available to all fdt-capable architectures.  Would
you be okay with I enclosed it in an #ifdef CONFIG_MPC85xx, like this:

U_BOOT_CMD(
	fdt,	255,	0,	do_fdt,
	"flattened device tree utility commands",
	    "addr   <addr> [<length>]        - Set the fdt location to <addr>\n"
#ifdef CONFIG_OF_BOARD_SETUP
	"fdt boardsetup                      - Do board-specific set up\n"
#endif
	"fdt move   <fdt> <newaddr> <length> - Copy the fdt to <addr> and make it active\n"
...
#ifdef CONFIG_MPC85xx
	"fdt verify                          - Verify the addresses in the device tree\n"
#endif
	"NOTE: Dereference aliases by omiting the leading '/', "
		"e.g. fdt print ethernet0."
);

-- 
Timur Tabi
Linux kernel developer at Freescale