public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work
Date: Wed, 17 Nov 2010 08:54:00 +0100	[thread overview]
Message-ID: <4CE38A18.2040709@denx.de> (raw)
In-Reply-To: <AANLkTim4k-PnuFDgWvYj3TY4mtLcz7Uzy1-TO9vExxbS@mail.gmail.com>

On 11/17/2010 08:29 AM, Jason Liu wrote:
> Agree. But I think the original commit for 128KiB env size has been
> reviewed on the mail list and no one against it.

This does not mean that we cannot change this value when we find it is
wrong....

And as I said previously, the value had no effect because
CONFIG_ENV_NOWHERE was set.

> So, I keep the same setting. If I change it, some guys main complain
> why it change,

There is not at the moment the possibility to store the environment in
the mainline for the mx51evk, nobody complains about a feature that does
not exist....

> We really don't know what data that customer will store. So leave much
> room for them is
> my first though, But consider the fast boot, what you said make sense.

If someone really needs a so large environment, cand send an e-mail to
this ML explaining his reason and posting a patch. It will be discussed
here.

> OK,  do you think we need change all the platform to reflect the 16K
> env size for MMC case?

Your patch refers to the mx51evk. So change the value according to this
discussion and post your patch again for inclusion in mainline. We will
take into account for other boards when new patches will be submitted.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2010-11-17  7:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16  8:41 [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work Jason Liu
2010-11-16 17:28 ` Stefano Babic
2010-11-17  1:44   ` Jason Liu
2010-11-17  7:03     ` Wolfgang Denk
2010-11-17  7:29       ` Jason Liu
2010-11-17  7:42         ` Wolfgang Denk
2010-11-17 21:28           ` Scott Wood
2010-11-17 21:50             ` Wolfgang Denk
2010-11-17  7:54         ` Stefano Babic [this message]
2010-11-17  8:03           ` Jason Liu
2010-11-17 13:00             ` Wolfgang Denk
2010-11-17  7:44     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE38A18.2040709@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox