From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2][NEXT] Davinci 8xx: Move common functions to share code
Date: Wed, 17 Nov 2010 17:47:00 +0100 [thread overview]
Message-ID: <4CE40704.20603@denx.de> (raw)
In-Reply-To: <AANLkTindJoHYDsQ1pVK6oz5u9dQgzS7uFxscRjura3J6@mail.gmail.com>
On 11/17/2010 05:26 PM, Ben Gardiner wrote:
> Hi Stefano,
>
Hi Ben,
> I was unable to test this series on top of Sugosh's and my patches
> even after re-basing my patch on top of his by moving the
> da850_emac_mii_mode_sel declaration from
> board/davinci/da8xxevm/common.h to the location from which you have
> removed it above.
>
> It looked like the removal of this file also needs to move the kick
> register declarations that Sugosh added here.
>
> I'm guessing you are working from a tree that is very close but not
> quite equal to mainline plus the patches you referenced in the cover
> letter.
Let's see. I am working on TOT of u-boot mainline, and I have applied
Sugosh's and your patch. Last u-boot commit in mainline is:
commit 8ad25bf8d9233eb7d0b614612108622a59069354
Author: Ben Warren <biggerbadderben@gmail.com>
Date: Tue Aug 31 23:05:04 2010 -0700
Net: clarify board/cpu_eth_init calls
I have then applied in the order the two SPI flash I have already sent
and you tested, Sugosh's patch and your patch. At the very top there is
my patchset. This is my git log, I drop some part of the commit id to
avoid wrapping:
6a1b17dd5cdaeb4c Davinci: add support for the ea20 board
5195253f20d5bedb Davinci 8xx: Move common functions to share code
8e6ed317d74b3b4d da850: Add RMII support for EMAC
9c1455c63dafc292 Move and rename common headers from under board/davinci.
4ccdfedb55b65f30 da850: Enable SPI Flash
0aacad5f81caac89 da8xx: Add cpu_is_da8xx macros
8ad25bf8d9233eb7 Net: clarify board/cpu_eth_init calls
^
|------- this is actual u-boot TOT
I think it is correct - patches are always sent on the actual u-boot
TOT. However, in this case my patches need that other patches (yours and
Sugosh's) are applied. I have tried to apply patches in the same order I
have seen, but we can have a different order.
> I don't know what is the best way to proceed... I like the current
> state of this patch series. I was unable to apply the three patch
> series (Sugosh's, Yours and mine) in any order without conflicts.
Let's see if something is missing ;-)
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2010-11-17 16:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 10:09 [U-Boot] Davinci: add support for ea20 board Stefano Babic
2010-11-17 10:09 ` [U-Boot] [PATCH 1/2][NEXT] Davinci 8xx: Move common functions to share code Stefano Babic
2010-11-17 16:26 ` Ben Gardiner
2010-11-17 16:47 ` Stefano Babic [this message]
2010-11-18 21:50 ` Ben Gardiner
2010-11-19 6:06 ` Stefano Babic
2010-11-19 7:23 ` Sughosh Ganu
2010-11-23 16:55 ` sughosh ganu
2010-11-23 18:05 ` Stefano Babic
2010-11-23 18:25 ` Paulraj, Sandeep
2010-11-23 18:31 ` Ben Gardiner
2010-11-23 18:38 ` Paulraj, Sandeep
2010-11-23 18:44 ` Ben Gardiner
2010-11-23 18:44 ` Paulraj, Sandeep
2010-11-23 18:53 ` Ben Gardiner
2010-11-23 18:57 ` Paulraj, Sandeep
2010-11-23 18:59 ` Ben Gardiner
2010-11-24 5:47 ` Sughosh Ganu
2010-11-18 5:26 ` Sughosh Ganu
2010-11-18 13:32 ` Ben Gardiner
2010-11-19 14:35 ` [U-Boot] [PATCH V2 1/2] " Stefano Babic
2010-11-19 15:16 ` Ben Gardiner
2010-11-22 7:28 ` Stefano Babic
2010-11-22 14:33 ` Ben Gardiner
2010-11-22 15:52 ` Paulraj, Sandeep
2010-11-24 7:23 ` Sughosh Ganu
2010-11-24 16:27 ` Ben Gardiner
2010-11-19 14:35 ` [U-Boot] [PATCH V2 2/2] Davinci: add support for the ea20 board Stefano Babic
2010-11-17 10:09 ` [U-Boot] [PATCH V6 2/2][NEXT] " Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE40704.20603@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox