From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Wed, 17 Nov 2010 12:40:50 -0600
Subject: [U-Boot] [PATCH] [v2] powerpc/85xx: introduce 'fdt verify'
	command
In-Reply-To: <20101117182348.F067614EA7E@gemini.denx.de>
References: <1290015805-18791-1-git-send-email-timur@freescale.com>
	<20101117182348.F067614EA7E@gemini.denx.de>
Message-ID: <4CE421B2.8010404@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
>> >  struct fdt_header *working_fdt;
>> > @@ -436,6 +450,10 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
>> >  	else if (strncmp(argv[1], "re", 2) == 0) {
>> >  		fdt_resize(working_fdt);
>> >  	}
>> > +	/* verify the addresses in the fdt */
>> > +	else if (argv[1][0] == 'v') {
>> > +		fdt_verify_addresses(working_fdt);
>> > +	}
>> >  	else {
> 2x incorrect coding style - the "else" goes on the saame line with the
> '}' and the '{'
> 

Ah, the bottom half of the switch statement uses this style:

}
else if


But the top half uses this style:

} else if

And the top half is correct.

-- 
Timur Tabi
Linux kernel developer at Freescale