From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 1/1] imx: Get fec mac address from fuse
Date: Thu, 18 Nov 2010 11:55:00 +0100 [thread overview]
Message-ID: <4CE50604.2060204@denx.de> (raw)
In-Reply-To: <AANLkTimmuK=_25zeN84Hz_k-hx3HMxqSaop0TkLX9CYm@mail.gmail.com>
On 11/18/2010 11:33 AM, Jason Liu wrote:
>>
>>> + for (i = 0; i < 6; i++)
>>> + mac[6-1-i] = readl(&fuse->mac_addr[i]);
>> ^
>> |--- missing spaces
>
> do you mean it need change to mac[6 - 1 - i] ?
Yes, this is a coding style issue.
> I think that the original mx27 code should be wrong.
I come with the same conclusion.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2010-11-18 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 8:09 [U-Boot] [PATCH v5 1/1] imx: Get fec mac address from fuse Jason Liu
2010-11-18 9:06 ` Stefano Babic
2010-11-18 10:33 ` Jason Liu
2010-11-18 10:55 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE50604.2060204@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox