From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Thu, 18 Nov 2010 11:55:00 +0100
Subject: [U-Boot] [PATCH v5 1/1] imx: Get fec mac address from fuse
In-Reply-To: <AANLkTimmuK=_25zeN84Hz_k-hx3HMxqSaop0TkLX9CYm@mail.gmail.com>
References: <1290067754-28200-1-git-send-email-r64343@freescale.com>	<4CE4EC97.4040802@denx.de>
	<AANLkTimmuK=_25zeN84Hz_k-hx3HMxqSaop0TkLX9CYm@mail.gmail.com>
Message-ID: <4CE50604.2060204@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/18/2010 11:33 AM, Jason Liu wrote:
>>
>>> +     for (i = 0; i < 6; i++)
>>> +             mac[6-1-i] = readl(&fuse->mac_addr[i]);
>>                     ^
>>                     |--- missing spaces
> 
> do you mean it need change to mac[6 - 1 - i] ?

Yes, this is a coding style issue.

> I think that the original mx27 code should be wrong.

I come with the same conclusion.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================