From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: allocate pre-relocation global_data on pre-relocation stack
Date: Thu, 18 Nov 2010 14:53:09 +0100 [thread overview]
Message-ID: <4CE52FC5.1030509@emk-elektronik.de> (raw)
In-Reply-To: <1289750861-23050-1-git-send-email-u-boot@emk-elektronik.de>
> That removes the need to reserve memory above the stack
> and also removes the need for GENERATED_GBL_DATA_SIZE.
> Alignment is automatically "right" provided stack is
> aligned.
>
> Signed-off-by: Reinhard Meyer <u-boot@emk-elektronik.de>
> ---
> arch/arm/lib/board.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 1fd5f83..53e0f4f 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -274,11 +274,12 @@ void board_init_f (ulong bootflag)
> init_fnc_t **init_fnc_ptr;
> gd_t *id;
> ulong addr, addr_sp;
> + gd_t auto_gd;
>
> /* Pointer is writable since we allocated a register for it */
> - gd = (gd_t *) (CONFIG_SYS_INIT_SP_ADDR);
> + gd = &auto_gd;
> /* compiler optimization barrier needed for GCC >= 3.4 */
> - __asm__ __volatile__("": : :"memory");
> + /* __asm__ __volatile__("": : :"memory"); */
>
> memset ((void*)gd, 0, sizeof (gd_t));
>
Are there any objections to this patch now?
I can provide a V2 where the "compiler optimization barrier" stuff is
completely removed.
Tested on: at91sam9xe / arm926ejs / top9000 and at91sam9xe-ek boards.
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-11-18 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 16:07 [U-Boot] [PATCH] ARM: allocate pre-relocation global_data on pre-relocation stack Reinhard Meyer
2010-11-14 16:20 ` Wolfgang Denk
2010-11-18 13:53 ` Reinhard Meyer [this message]
2010-11-18 16:02 ` Albert ARIBAUD
2010-11-18 20:43 ` Reinhard Meyer
2010-11-18 20:51 ` Albert ARIBAUD
2010-11-28 5:36 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE52FC5.1030509@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox