[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[Stephan Linz]

Hi Ben,
Hi Michal,

in terms of your last communication:

http://www.mail-archive.com/u-boot at lists.denx.de/msg36959.html

... I want ask about the state of the review. When will the patch be added in 
the mainstream?

As far as I can see there were more than a try to submit the patch:
http://www.mail-archive.com/u-boot at lists.denx.de/msg35518.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg08025.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg06789.html

@Ben: What's wrong?

@Michal: Where can I find the latest commit for cherry-pick?


-- 
Best regards,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L

[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[Michal Simek]

Hi Stephan,

Stephan Linz wrote:
> Hi Ben,
> Hi Michal,
> 
> in terms of your last communication:
> 
> http://www.mail-archive.com/u-boot at lists.denx.de/msg36959.html
> 
> ... I want ask about the state of the review. When will the patch be added in 
> the mainstream?

 From my point of view. I am not pushing Ben and Ben has to give up 
Network custodianship.

> 
> As far as I can see there were more than a try to submit the patch:
> http://www.mail-archive.com/u-boot at lists.denx.de/msg35518.html
> http://www.mail-archive.com/u-boot at lists.denx.de/msg08025.html
> http://www.mail-archive.com/u-boot at lists.denx.de/msg06789.html
> 
> @Ben: What's wrong?
> 
> @Michal: Where can I find the latest commit for cherry-pick?

You can look at this.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

Michal





-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[Stephan Linz]

Hi Michal,

Am Mittwoch, 17. November 2010, um 11:38:07 schrieb Michal Simek:
> Hi Stephan,
>
> Stephan Linz wrote:
> > Hi Ben,
> > Hi Michal,
> >
> > in terms of your last communication:
> >
> > http://www.mail-archive.com/u-boot at lists.denx.de/msg36959.html
> >
> > ... I want ask about the state of the review. When will the patch be
> > added in the mainstream?

OK, things are coming and going -- that's live.

>
>  From my point of view. I am not pushing Ben and Ben has to give up
> Network custodianship.
>
> > As far as I can see there were more than a try to submit the patch:
> > http://www.mail-archive.com/u-boot at lists.denx.de/msg35518.html
> > http://www.mail-archive.com/u-boot at lists.denx.de/msg08025.html
> > http://www.mail-archive.com/u-boot at lists.denx.de/msg06789.html
> >
> > @Ben: What's wrong?
> >
> > @Michal: Where can I find the latest commit for cherry-pick?
>
> You can look at this.
> http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

Thank you very much for your fast reaction. I'll try out the new 
implementation on my SP3ADSP1800 and ML605 and ACK here on u-boot list. Give 
me time until Friday.


-- 
Best regards,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L

[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[Stephan Linz]

Am Mittwoch, 17. November 2010, um 13:15:24 schrieb Stephan Linz:
> Hi Michal,
>
> --snip--
> > >
> > > @Michal: Where can I find the latest commit for cherry-pick?
> >
> > You can look at this.
> > http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary
>
> Thank you very much for your fast reaction. I'll try out the new
> implementation on my SP3ADSP1800 and ML605 and ACK here on u-boot list.
> Give me time until Friday.

Hi Michal,

thanks again. I've to fixed some bugs. The corresponding patches I will send 
in a separeted e-mail. Watch the mailing list / your inbox.

Now most things are working (see dump below) but sometimes I get more or less 
LEN messages (ex.: len bad 156 < 208). Can you confirm this? I think it is not 
a problem with the driver, or not?


U-Boot-mONStR> dhcp 0x20900000 /ml605/linuximage.ub
Xilinx_LL_TEMAC: Xilinx XPS LocalLink Tri-Mode Ether MAC #0 at 0x88F00000.
Looking for phy ... OK
Waiting for link ... OK
100BASE-T/FD
BOOTP broadcast 1
DHCP client bound to address 192.168.10.175
Using Xilinx_LL_TEMAC device
TFTP from server 192.168.10.10; our IP address is 192.168.10.175
Filename '/ml605/linuximage.ub'.
Load address: 0x20900000
Loading: #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         ##############
done
Bytes transferred = 7837764 (779844 hex)


-- 
Best regards,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L

[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[Michal Simek]

Stephan Linz wrote:
> Am Mittwoch, 17. November 2010, um 13:15:24 schrieb Stephan Linz:
>> Hi Michal,
>>
>> --snip--
>>>> @Michal: Where can I find the latest commit for cherry-pick?
>>> You can look at this.
>>> http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary
>> Thank you very much for your fast reaction. I'll try out the new
>> implementation on my SP3ADSP1800 and ML605 and ACK here on u-boot list.
>> Give me time until Friday.
> 
> Hi Michal,
> 
> thanks again. I've to fixed some bugs. The corresponding patches I will send 
> in a separeted e-mail. Watch the mailing list / your inbox.
> 
> Now most things are working (see dump below) but sometimes I get more or less 
> LEN messages (ex.: len bad 156 < 208). Can you confirm this? I think it is not 
> a problem with the driver, or not?

IMHO it has connection with your lan traffic. U-boot expect specific 
packet len but got different one.

Haven't had time to look your changes but hopefully I'll look at it 
hopefully soon.

Michal



> 
> 
> U-Boot-mONStR> dhcp 0x20900000 /ml605/linuximage.ub
> Xilinx_LL_TEMAC: Xilinx XPS LocalLink Tri-Mode Ether MAC #0 at 0x88F00000.
> Looking for phy ... OK
> Waiting for link ... OK
> 100BASE-T/FD
> BOOTP broadcast 1
> DHCP client bound to address 192.168.10.175
> Using Xilinx_LL_TEMAC device
> TFTP from server 192.168.10.10; our IP address is 192.168.10.175
> Filename '/ml605/linuximage.ub'.
> Load address: 0x20900000
> Loading: #################################################################
>          #################################################################
>          #################################################################
>          #################################################################
>          #################################################################
>          #################################################################
>          #################################################################
>          #################################################################
>          ##############
> done
> Bytes transferred = 7837764 (779844 hex)
> 
> 


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

[U-Boot] RFC: missing patch review for LL TEMAC driver to u-boot

[Stephan Linz]

Am Donnerstag, 25. November 2010, um 10:25:02 schrieb Michal Simek:
> Stephan Linz wrote:
> > Am Mittwoch, 17. November 2010, um 13:15:24 schrieb Stephan Linz:
> >> Hi Michal,
> >>
> >> --snip--
> >
> > Hi Michal,
> >
> > thanks again. I've to fixed some bugs. The corresponding patches I will
> > send in a separeted e-mail. Watch the mailing list / your inbox.
> >
> > Now most things are working (see dump below) but sometimes I get more or
> > less LEN messages (ex.: len bad 156 < 208). Can you confirm this? I think
> > it is not a problem with the driver, or not?
>
> IMHO it has connection with your lan traffic. U-boot expect specific
> packet len but got different one.

I think so too without to explore the whole network traffic. I will repeat my 
tests in another network (as fast as possible). Thanks for your efforts.

>
> Haven't had time to look your changes but hopefully I'll look at it
> hopefully soon.

It's ok. 


Stephan

>
> Michal
>
> > U-Boot-mONStR> dhcp 0x20900000 /ml605/linuximage.ub
> > Xilinx_LL_TEMAC: Xilinx XPS LocalLink Tri-Mode Ether MAC #0 at
> > 0x88F00000. Looking for phy ... OK
> > Waiting for link ... OK
> > 100BASE-T/FD
> > BOOTP broadcast 1
> > DHCP client bound to address 192.168.10.175
> > Using Xilinx_LL_TEMAC device
> > TFTP from server 192.168.10.10; our IP address is 192.168.10.175
> > Filename '/ml605/linuximage.ub'.
> > Load address: 0x20900000
> > Loading:
> > #################################################################
> > #################################################################
> > #################################################################
> > #################################################################
> > #################################################################
> > #################################################################
> > #################################################################
> > #################################################################
> > ##############
> > done
> > Bytes transferred = 7837764 (779844 hex)


-- 
Viele Gr??e,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L