[U-Boot] [PATCH] Fix compiler warning in fdt_support.c

[U-Boot] [PATCH] Fix compiler warning in fdt_support.c

[dirk.behme at googlemail.com]

From: Dirk Behme <dirk.behme@googlemail.com>

Fix compiler warning

fdt_support.c: In function 'of_bus_default_count_cells':
fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type

be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'.

Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>

---

Found while building 'omap3_beagle'.

 common/fdt_support.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: u-boot.git/common/fdt_support.c
===================================================================
--- u-boot.git.orig/common/fdt_support.c
+++ u-boot.git/common/fdt_support.c
@@ -954,7 +954,7 @@ static void of_bus_default_count_cells(v
 	if (addrc) {
 		prop = fdt_getprop(blob, parentoffset, "#address-cells", NULL);
 		if (prop)
-			*addrc = be32_to_cpup(prop);
+			*addrc = be32_to_cpup((u32 *)prop);
 		else
 			*addrc = 2;
 	}
@@ -962,7 +962,7 @@ static void of_bus_default_count_cells(v
 	if (sizec) {
 		prop = fdt_getprop(blob, parentoffset, "#size-cells", NULL);
 		if (prop)
-			*sizec = be32_to_cpup(prop);
+			*sizec = be32_to_cpup((u32 *)prop);
 		else
 			*sizec = 1;
 	}

[U-Boot] [PATCH] Fix compiler warning in fdt_support.c

[Albert ARIBAUD]

Le 21/11/2010 20:19, dirk.behme at googlemail.com a ?crit :
> From: Dirk Behme<dirk.behme@googlemail.com>
>
> Fix compiler warning
>
> fdt_support.c: In function 'of_bus_default_count_cells':
> fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
> fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
>
> be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'.
>
> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>
> ---
>
> Found while building 'omap3_beagle'.
>
>   common/fdt_support.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: u-boot.git/common/fdt_support.c
> ===================================================================
> --- u-boot.git.orig/common/fdt_support.c
> +++ u-boot.git/common/fdt_support.c
> @@ -954,7 +954,7 @@ static void of_bus_default_count_cells(v
>   	if (addrc) {
>   		prop = fdt_getprop(blob, parentoffset, "#address-cells", NULL);
>   		if (prop)
> -			*addrc = be32_to_cpup(prop);
> +			*addrc = be32_to_cpup((u32 *)prop);
>   		else
>   			*addrc = 2;
>   	}
> @@ -962,7 +962,7 @@ static void of_bus_default_count_cells(v
>   	if (sizec) {
>   		prop = fdt_getprop(blob, parentoffset, "#size-cells", NULL);
>   		if (prop)
> -			*sizec = be32_to_cpup(prop);
> +			*sizec = be32_to_cpup((u32 *)prop);
>   		else
>   			*sizec = 1;
>   	}

Maybe we could pull this patch in? That will raise the count of ARM 
boards building clean.

Amicalement,
-- 
Albert.

[U-Boot] [PATCH] Fix compiler warning in fdt_support.c

[Wolfgang Denk]

Dear dirk.behme at googlemail.com,

In message <1290367174-380-1-git-send-email-dirk.behme@gmail.com> you wrote:
> From: Dirk Behme <dirk.behme@googlemail.com>
> 
> Fix compiler warning
> 
> fdt_support.c: In function 'of_bus_default_count_cells':
> fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
> fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
> 
> be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'.
> 
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
> 
> ---
> 
> Found while building 'omap3_beagle'.

Applied, thank.

Gerry, hope this is OK with you.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I object to intellect without discipline;  I object to power without
constructive purpose.
	-- Spock, "The Squire of Gothos", stardate 2124.5

[U-Boot] [PATCH] Fix compiler warning in fdt_support.c

[Gerald Van Baren]

On 11/28/2010 06:42 AM, Wolfgang Denk wrote:
> Dear dirk.behme at googlemail.com,
>
> In message<1290367174-380-1-git-send-email-dirk.behme@gmail.com>  you wrote:
>> From: Dirk Behme<dirk.behme@googlemail.com>
>>
>> Fix compiler warning
>>
>> fdt_support.c: In function 'of_bus_default_count_cells':
>> fdt_support.c:957: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
>> fdt_support.c:965: warning: passing argument 1 of '__swab32p' discards qualifiers from pointer target type
>>
>> be32_to_cpup() expects an 'u32 *' while prop is 'const u32 *'.
>>
>> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>>
>> ---
>>
>> Found while building 'omap3_beagle'.
>
> Applied, thank.
>
> Gerry, hope this is OK with you.

Yes, thanks.

> Best regards,
> Wolfgang Denk

Best regards,
gvb