[U-Boot] Build failures with older toolchain

Premi, Sanjeev
2010-11-29T11:48:15Z

> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Monday, November 29, 2010 5:00 PM
> To: Premi, Sanjeev
> Cc: Albert ARIBAUD; u-boot at lists.denx.de
> Subject: Re: [U-Boot] Build failures with older toolchain

[snip]

> > I had been holding this patch until until the problem is
> > really solved - just in case there was a relation.
>
> You mean you are complaining about problems with code you have
> modified locally, and then expect us to diagnose your problems without
> even telling us 1) that you changed the code and 2) what exactly you
> changed?

[sp] In my original message I did mention about local change. At least,
then, I believed them to be unrelated... and mentioned so.

>
> This patch is corrupted.and does not apply. Please see
> http://www.denx.de/wiki/U-Boot/Patches
>

[sp] I shared the patch with Albert off-the-list as he had planned
to work on it... It was to indicate the change that I was doing.

BTW, I now notice that few chars on the pasted diff seem to have
been trimed (not sure why) therefore patch didn't apply. Should
have been more careful...

I have posted an updated patch refreshed against the latest
master few mins back.

>
> I have no idea if it results in a running system (as I have no
> hardware to test it), but I can confirm that a patch like this:
>
> diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> index 84b2986..f3df8de 100644
> --- a/include/configs/omap3_evm.h
> +++ b/include/configs/omap3_evm.h
> @@ -330,7 +330,7 @@ extern unsigned int boot_flash_type;
> * Support for relocation
> */
> #define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
> -#define CONFIG_SYS_INIT_SP_ADDR
> (LOW_LEVEL_SRAM_STACK - CONFIG_SYS_GBL_DATA_SIZE)
> +#define CONFIG_SYS_INIT_SP_ADDR
> (LOW_LEVEL_SRAM_STACK - GENERATED_GBL_DATA_SIZE)

[sp] Although, you the patch I send earlier didn't apply cleanly,
I was making the same change... and noticing the failures.

As mentioned earlier, I did not expect to see any errors after
making this change.

I am process of downloading the 2009q3 version from codesourcery
Albert mentioned he is using it. Are you on the same version as
well?

~sanjeev

[snip]