From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 29 Nov 2010 18:25:31 +0100 Subject: [U-Boot] [PATCH] OMAP-common/timer: Fix bss usage In-Reply-To: <1291046912-15167-1-git-send-email-weber@corscience.de> References: <20101129124847.E1D8111D94F2@gemini.denx.de> <1291046912-15167-1-git-send-email-weber@corscience.de> Message-ID: <4CF3E20B.1090705@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Thomas, Thomas Weber wrote: > This patch fixes the bss usage in ARMv7/omap-common/timer.c > > The .bss section cannot be used before the relocation, because this > section is overlayed with .rel.dyn section. > > Suggested-by: Andreas Biessmann > Signed-off-by: Thomas Weber > --- > arch/arm/cpu/armv7/omap-common/timer.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/cpu/armv7/omap-common/timer.c b/arch/arm/cpu/armv7/omap-common/timer.c > index 6b8cf7b..b649b93 100644 > --- a/arch/arm/cpu/armv7/omap-common/timer.c > +++ b/arch/arm/cpu/armv7/omap-common/timer.c > @@ -35,8 +35,8 @@ > #include > #include > > -static ulong timestamp; > -static ulong lastinc; > +static ulong timestamp = 0; > +static ulong lastinc = 0; > static struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE; > > /* > @@ -54,8 +54,6 @@ int timer_init(void) > writel((CONFIG_SYS_PTV << 2) | TCLR_PRE | TCLR_AR | TCLR_ST, > &timer_base->tclr); > > - reset_timer_masked(); /* init the timestamp and lastinc value */ > - > return 0; > } Is this Ok? In actual reset_timer_masked() lastinc gets initialized with: lastinc = readl(&timer_base->tcrr) / (TIMER_CLOCK / CONFIG_SYS_HZ); and your patch changes that to lastinc = 0 ... bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany