From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert@aribaud.net>
Date: Tue, 30 Nov 2010 09:07:05 +0100
Subject: [U-Boot] [PATCH RFC 1/3] arm920t: do not set register useless
In-Reply-To: <1291100800-61850-2-git-send-email-andreas.devel@googlemail.com>
References: <1291100800-61850-1-git-send-email-andreas.devel@googlemail.com>
	<1291100800-61850-2-git-send-email-andreas.devel@googlemail.com>
Message-ID: <4CF4B0A9.6030209@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Andreas,

Le 30/11/2010 08:06, Andreas Bie?mann a ?crit :

> diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S
> index 01edb9b..71de373 100644
> --- a/arch/arm/cpu/arm920t/start.S
> +++ b/arch/arm/cpu/arm920t/start.S
> @@ -208,15 +208,16 @@ stack_setup:
>   	mov	sp, r4
>
>   	adr	r0, _start
> +	cmp	r0, r6
> +	beq	clear_bss		/* skip relocation */
> +	mov	r1, r6

Why use r1?

>   	ldr	r2, _TEXT_BASE
>   	ldr	r3, _bss_start_ofs
>   	add	r2, r0, r3		/* r2<- source end address	    */
> -	cmp	r0, r6
> -	beq	clear_bss
>
>   copy_loop:
>   	ldmia	r0!, {r9-r10}		/* copy from source address [r0]    */
> -	stmia	r6!, {r9-r10}		/* copy to   target address [r1]    */
> +	stmia	r1!, {r9-r10}		/* copy to   target address [r1]    */

Ditto.

>   	cmp	r0, r2			/* until source end address [r2]    */
>   	blo	copy_loop

Amicalement,
-- 
Albert.