[U-Boot] [PATCH RFC 3/3] arm920t: do not relocate NULL pointer

Joakim Tjernlund
2010-11-30T08:47:07Z

>
> Le 30/11/2010 08:06, Andreas Bie?mann a ?crit :
> > Signed-off-by: Andreas Bie?mann<andreas.devel@googlemail.com>
>
> > + cmp r1, #0 /* symbol == NULL ? */
> > + beq fixnext
>
> Nak. Don't hide a null pointer. NULL pointers are *not* relocated, since
> they are a constant. If a NULL ends up in relocation tables, that is
> because of a corruption *or* because it was to be relocated, and should
> thus never be ignored.

Depends, if the same routine is used for relocating fixups you need
this test. Undefined weaks will generate a NULL fixup entry.

Jocke