From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 30 Nov 2010 09:32:33 +0100 Subject: [U-Boot] [PATCH RFC 3/3] arm920t: do not relocate NULL pointer In-Reply-To: <1291100800-61850-4-git-send-email-andreas.devel@googlemail.com> References: <1291100800-61850-1-git-send-email-andreas.devel@googlemail.com> <1291100800-61850-4-git-send-email-andreas.devel@googlemail.com> Message-ID: <4CF4B6A1.7090509@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 30/11/2010 08:06, Andreas Bie?mann a ?crit : > Signed-off-by: Andreas Bie?mann > + cmp r1, #0 /* symbol == NULL ? */ > + beq fixnext Nak. Don't hide a null pointer. NULL pointers are *not* relocated, since they are a constant. If a NULL ends up in relocation tables, that is because of a corruption *or* because it was to be relocated, and should thus never be ignored. Amicalement, -- Albert.