From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] arm920t/at91/timer: replace bss variables by gd
Date: Tue, 30 Nov 2010 09:48:03 +0100 [thread overview]
Message-ID: <4CF4BA43.1000703@gmail.com> (raw)
In-Reply-To: <20101130081628.B76ADEA65E5@gemini.denx.de>
Dear Wolfgang Denk,
Am 30.11.2010 09:16, schrieb Wolfgang Denk:
> Dear "=?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?=",
>
> In message <4CF4AFED.1010609@gmail.com> you wrote:
>>
>> To get this bss issue fixed for v2010.12 I'd like to add another value
>> to GD to hold the last hw timer value. My current usage of tbu should
>> therefore go to tbl, to have a virutal 64 bit value just counting 32
>> bit, is that right?
>
> That sounds like a terrible mess to me, please do not do that. Either
> we have a 64 bit counter, hen it should cound the full 64 bit range.
> Or use a plain uint32_t if 32 bit are sfficient. Don't play any
> tricks like misusing an "unused" part of one variable for other,
> independent purposes.
If I got Reinhard correct the uint32 values tbl and tbu do build the
Upper and Lower part of an virtual 64 bit counter. His statement is to
not use these values in another context like I did (32 bit timestamp and
32 bit 'lastinc' which is really 16 bit). Therefore I additionally
suggested to have the idea with virtual 64 bit reproduced for at91rm9200
and use the lower part for timestamp.
> I think we should provide a "uint64_t timebase" which represents a
> real 64 bit counter. And if you need a separate "uint32_t timelast"
> to store the previous timer value then please make this a separate
> variable.
As you suggested in another thread those changes will go into next
branch. So for v2010.12 I'd like to have a 'short time' solution to get
the at91rm9200 boards working. Is it OK to use the tbu/tbl values as
mentioned above and then migrate to a uint64_t timebase later on?
regards
Andreas Bie?mann
next prev parent reply other threads:[~2010-11-30 8:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 6:37 [U-Boot] [PATCH 0/4] get at91rm9200ek working with ARM relocation Andreas Bießmann
2010-11-30 6:37 ` [U-Boot] [PATCH 1/4] at91rm9200ek: add configure target for RAM boot Andreas Bießmann
2010-11-30 6:37 ` [U-Boot] [PATCH 2/4] MAKEALL: fix AT91 Andreas Bießmann
2010-11-30 6:37 ` [U-Boot] [PATCH 3/4] arm920t: fix linker skript for -pie linking Andreas Bießmann
2010-12-08 22:52 ` Wolfgang Denk
2010-12-09 7:24 ` Andreas Bießmann
2010-12-09 7:33 ` Albert ARIBAUD
2010-12-09 9:45 ` Wolfgang Denk
2010-12-09 10:32 ` Wolfgang Denk
2010-12-09 10:51 ` Andreas Bießmann
2010-11-30 6:37 ` [U-Boot] [PATCH 4/4] arm920t/at91/timer: replace bss variables by gd Andreas Bießmann
2010-11-30 7:17 ` Reinhard Meyer
2010-11-30 8:03 ` Andreas Bießmann
2010-11-30 8:16 ` Wolfgang Denk
2010-11-30 8:48 ` Andreas Bießmann [this message]
2010-11-30 9:14 ` [U-Boot] TIMER cleanup RFC, was: " Reinhard Meyer
2010-11-30 15:11 ` J. William Campbell
2010-11-30 15:48 ` Reinhard Meyer
2010-11-30 17:29 ` J. William Campbell
2010-11-30 18:06 ` [U-Boot] [PATCH 0/4] get at91rm9200ek working with ARM relocation Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF4BA43.1000703@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox