[U-Boot] [PATCH v2] BLOCK: Add freescale IMX51 PATA driver

[Stefano Babic <sbabic@denx.de>]

On 11/30/2010 04:26 AM, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> v2: Use structures instead of defines as Wolfgang proposed
> 

Hi Marek,

>  drivers/block/Makefile  |    1 +
>  drivers/block/mxc_ata.c |  149 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 150 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/block/mxc_ata.c

In which context does this driver run ? I thought to find a similar
implementation I see, for example, in pata_bfin.c, with entry points to
read/write data, but I cannot see them. I assume you set only
CONFIG_CMD_IDE for testing.

On which board do you plan to add this P-ATA driver ?

Trying to apply this driver give me a link error:
/home/stefano/Projects/imx/u-boot-imx/common/cmd_ide.c:905: undefined
reference to `outsw'
common/libcommon.o: In function `input_data':
/home/stefano/Projects/imx/u-boot-imx/common/cmd_ide.c:963: undefined
reference to `insw'
common/libcommon.o: In function `__ide_inb':
/home/stefano/Projects/imx/u-boot-imx/common/cmd_ide.c:530: undefined
reference to `inb'

This functions are not implemented for the i.MX51 SOC.

> +	/* Configure the PIO timing */
> +	set_ata_bus_timing(CONFIG_MXC_ATA_PIO_MODE);

CONFIG_MXC_ATA_PIO_MODE is a new parameter, to be set in board
configuration file. It should be documented in some ways.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================