public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
@ 2010-10-22  9:21 Andre Schwarz
  2010-10-23 20:12 ` Wolfgang Denk
  2010-11-28 15:09 ` Kim Phillips
  0 siblings, 2 replies; 6+ messages in thread
From: Andre Schwarz @ 2010-10-22  9:21 UTC (permalink / raw)
  To: u-boot

SICRH has been misconfigured, i.e. TSEC2 clock + D[0:3] are GPIOs.
Fix this to be RGMII signals again.

Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>
---

Kim,
sorry for late submission - this has been lingering around for a while.
Hopefully you can still appply it since it's a real bugfix.
Regards,
Andre

 include/configs/MVBLM7.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
index 28e0d1b..431e102 100644
--- a/include/configs/MVBLM7.h
+++ b/include/configs/MVBLM7.h
@@ -348,7 +348,7 @@
 #define CONFIG_SYS_SCCR_TSEC1CM	1
 #define CONFIG_SYS_SCCR_TSEC2CM	1
 
-#define CONFIG_SYS_SICRH	0x1fff8003
+#define CONFIG_SYS_SICRH	0x1fef0003
 #define CONFIG_SYS_SICRL	(SICRL_LDP_A | SICRL_USB1 | SICRL_USB0)
 
 #define CONFIG_SYS_HID0_INIT	0x000000000
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
  2010-10-22  9:21 [U-Boot] [PATCH] MVBLM7: make TSEC2 work again Andre Schwarz
@ 2010-10-23 20:12 ` Wolfgang Denk
  2010-11-28 15:09 ` Kim Phillips
  1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2010-10-23 20:12 UTC (permalink / raw)
  To: u-boot

Dear Andre Schwarz,

In message <1287739306-5758-1-git-send-email-andre.schwarz@matrix-vision.de> you wrote:
> SICRH has been misconfigured, i.e. TSEC2 clock + D[0:3] are GPIOs.
> Fix this to be RGMII signals again.
> 
> Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>
> ---
> 
> Kim,
> sorry for late submission - this has been lingering around for a while.
> Hopefully you can still appply it since it's a real bugfix.
> Regards,
> Andre
> 
>  include/configs/MVBLM7.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

applied, thanks.

Kim, I pulled this directly as it affects clearly this single board
only.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
War is never imperative.
	-- McCoy, "Balance of Terror", stardate 1709.2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
  2010-10-22  9:21 [U-Boot] [PATCH] MVBLM7: make TSEC2 work again Andre Schwarz
  2010-10-23 20:12 ` Wolfgang Denk
@ 2010-11-28 15:09 ` Kim Phillips
  2010-11-30 13:32   ` Andre Schwarz
  1 sibling, 1 reply; 6+ messages in thread
From: Kim Phillips @ 2010-11-28 15:09 UTC (permalink / raw)
  To: u-boot

On Fri, 22 Oct 2010 11:21:46 +0200
Andre Schwarz <andre.schwarz@matrix-vision.de> wrote:

> diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
> index 28e0d1b..431e102 100644
> --- a/include/configs/MVBLM7.h
> +++ b/include/configs/MVBLM7.h
> @@ -348,7 +348,7 @@
>  #define CONFIG_SYS_SCCR_TSEC1CM	1
>  #define CONFIG_SYS_SCCR_TSEC2CM	1
>  
> -#define CONFIG_SYS_SICRH	0x1fff8003
> +#define CONFIG_SYS_SICRH	0x1fef0003

please use SICRH_* defines to compose this value, as is done for SICRL.

Thanks,

Kim

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
  2010-11-28 15:09 ` Kim Phillips
@ 2010-11-30 13:32   ` Andre Schwarz
  2010-11-30 14:17     ` Wolfgang Denk
  0 siblings, 1 reply; 6+ messages in thread
From: Andre Schwarz @ 2010-11-30 13:32 UTC (permalink / raw)
  To: u-boot

Kim,
>> diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
>> index 28e0d1b..431e102 100644
>> --- a/include/configs/MVBLM7.h
>> +++ b/include/configs/MVBLM7.h
>> @@ -348,7 +348,7 @@
>>   #define CONFIG_SYS_SCCR_TSEC1CM	1
>>   #define CONFIG_SYS_SCCR_TSEC2CM	1
>>
>> -#define CONFIG_SYS_SICRH	0x1fff8003
>> +#define CONFIG_SYS_SICRH	0x1fef0003
>>      
> please use SICRH_* defines to compose this value, as is done for SICRL.
>    
ok - will do.

Since I have more stuff pending I'll wait for the merge window to open 
before re-submitting.

Regards,
Andr?


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
  2010-11-30 13:32   ` Andre Schwarz
@ 2010-11-30 14:17     ` Wolfgang Denk
  2010-11-30 14:49       ` Andre Schwarz
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2010-11-30 14:17 UTC (permalink / raw)
  To: u-boot

Dear Andre Schwarz,

In message <4CF4FCD6.80309@matrix-vision.de> you wrote:
>
> Since I have more stuff pending I'll wait for the merge window to open
> before re-submitting.

We have a "next" branch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If something is different, it's either better or worse,  and  usually
both.                                                    - Larry Wall

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] MVBLM7: make TSEC2 work again.
  2010-11-30 14:17     ` Wolfgang Denk
@ 2010-11-30 14:49       ` Andre Schwarz
  0 siblings, 0 replies; 6+ messages in thread
From: Andre Schwarz @ 2010-11-30 14:49 UTC (permalink / raw)
  To: u-boot

Wolfgang,

> Dear Andre Schwarz,
>
> In message<4CF4FCD6.80309@matrix-vision.de>  you wrote:
>    
>> Since I have more stuff pending I'll wait for the merge window to open
>> before re-submitting.
>>      
> We have a "next" branch.
>    

understood - will rebase on current master and resubmit immediately 
after testing has passed.
I've also had no time to double-check Jocke's 83xx patches for my boards 
so far ... it's about time.


Cheers,
Andr?


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-11-30 14:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-22  9:21 [U-Boot] [PATCH] MVBLM7: make TSEC2 work again Andre Schwarz
2010-10-23 20:12 ` Wolfgang Denk
2010-11-28 15:09 ` Kim Phillips
2010-11-30 13:32   ` Andre Schwarz
2010-11-30 14:17     ` Wolfgang Denk
2010-11-30 14:49       ` Andre Schwarz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox