[U-Boot] [PATCH] omap3evm: Clean-up EVM detection code.

Premi, Sanjeev
2010-12-02T13:30:38Z

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Thursday, December 02, 2010 5:07 PM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] omap3evm: Clean-up EVM detection code.
>
> Dear Sanjeev Premi,
>
> In message <1291288812-12653-1-git-send-email-premi@ti.com> you wrote:
> > This patch does following changes:
> > * Change the type (u8 -> int) for omap3_evm_version.
> > * Introduce an 'undefined' board revision for init
> > value.
> > * Use of #define instead of magic numbers
> >
> > Signed-off-by: Sanjeev Premi <premi@ti.com>
> > ---
> > board/ti/evm/evm.c | 39 +++++++++++++++++++++++----------------
> > board/ti/evm/evm.h | 17 +++++++----------
> > 2 files changed, 30 insertions(+), 26 deletions(-)
> >
> > diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c
> > index 09d14f7..8d9ce73 100644
> > --- a/board/ti/evm/evm.c
> > +++ b/board/ti/evm/evm.c
> > @@ -37,36 +37,43 @@
> > #include <asm/mach-types.h>
> > #include "evm.h"
> >
> > -static u8 omap3_evm_version;
> > +static int omap3_evm_version = OMAP3EVM_BOARD_UNDEF;
> ...
> > +#define OMAP3EVM_BOARD_UNDEF -1 /* EVM revision
> not detected */
>
> Sorry, but I will not accept this patch.
>
> The only purpose of this initialization with a non-zero value is to
> paper over a problem. As a result, the problem will be left unsolved,
> so it bites us again elsewhere, and we increase the memory footprint
> of the U-Boot image without need.

At least I haven't deserted the problem; but the patch will help some
one to test beyond the basic boot and see if there is any other impact
on the functionality.

The board has been broken for many weeks. As we see problem with
sort($LIBS); there could be more issues that are yet to be discovered.

~sanjeev

>
> NAK.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> You get a wonderful view from the point of no return.
> - Terry Pratchett, _Making_Money_
>