[U-Boot] [PATCH] omap3evm: Clean-up EVM detection code.

Wolfgang Denk
2010-12-02T13:58:04Z

Dear Albert ARIBAUD,

In message <4CF7922B.3020504@free.fr> you wrote:
>
> Now, on an unrelated note, omap3_emv's code arbitrarily uses an u8 where
> an int (or enum) would be more appropriate, and this should be changed
> not because it removes a linker warning, but because the u8 choice is
> arbitrary and at best as effective as using an int, at worst suboptimal
> to that.

Well, an u8 is as good a data type as any other. The available range
of 0...255 seems more than sufficient to store the needed
information, so why should I waste 4 bytes of storage when a single
byte is sufficient as well?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on, she wants to
start living her own life." "Whose life she's _been_ living, then?"
- Terry Pratchett, _Witches Abroad_