From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 1/3] tools/env: Default to the config specified in FW_CONFIG_FILE
Date: Sat, 04 Dec 2010 11:59:22 +0100 [thread overview]
Message-ID: <4CFA1F0A.9010509@denx.de> (raw)
In-Reply-To: <1291436933-26861-2-git-send-email-steve@sakoman.com>
On 12/04/2010 05:28 AM, Steve Sakoman wrote:
> From: Lo?c Minier <loic.minier@linaro.org>
>
Hi,
> #if defined(CONFIG_FILE)
> + /* Default to the config file specified in FW_CONFIG_FILE */
> + char *config_file = getenv("FW_CONFIG_FILE");
What about to pass the configuration file on the command line instead of
an environment variable ? Something like "fw_env -c /etc/fw_config", for
example ? IMHO it is easier to understand and we can add documentation
in the "help" message.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2010-12-04 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 4:28 [U-Boot] [RFC 0/3] Enhance env tools Steve Sakoman
2010-12-04 4:28 ` [U-Boot] [RFC 1/3] tools/env: Default to the config specified in FW_CONFIG_FILE Steve Sakoman
2010-12-04 10:34 ` Mike Frysinger
2010-12-04 14:44 ` Steve Sakoman
2010-12-04 10:59 ` Stefano Babic [this message]
2010-12-04 14:43 ` Steve Sakoman
2010-12-04 4:28 ` [U-Boot] [RFC 2/3] tools/env: Support writing to files Steve Sakoman
2010-12-04 10:37 ` Mike Frysinger
2010-12-04 14:42 ` Steve Sakoman
2010-12-04 11:23 ` Stefano Babic
2010-12-04 14:48 ` Steve Sakoman
2010-12-05 0:05 ` Loïc Minier
2010-12-04 4:28 ` [U-Boot] [RFC 3/3] tools/env: Bump devname length to PATH_MAX for filenames Steve Sakoman
2010-12-04 20:35 ` [U-Boot] [RFC 0/3] Enhance env tools Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFA1F0A.9010509@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox