From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 07 Dec 2010 08:47:24 +0100 Subject: [U-Boot] [PATCH] MX5: Add initial support for mx53 In-Reply-To: References: <1291633048-30247-1-git-send-email-r64343@freescale.com> <4CFD0A11.6070606@denx.de> Message-ID: <4CFDE68C.1070608@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/07/2010 03:58 AM, Jason Liu wrote: >> I know all this crap is for MX51 in the TO1 version, even if I do not >> know if there are boards with this first version of the processor. >> Probably we must maintain this stuff for compatibility. Really I would >> like to remove it completely ;-). > > Do you mind that I remove it completely here? Really I do not know. This is clearly a workaround for the first MX.51 version (TO1), and it makes no sense for actual processor's revision. I do not know if there are mx51evk with this revision on board, but if there are we should maintain this code for compatibility reason. > The motivation to use " is_soc_type(CPU_TYPE) "is to remove the some > #ifdef CONFIG_MX51in this file, > I can change back to the following, > > + #if defined (MX_CPU_MX51) > + if (is_soc_rev(CHIP_REV_2_0) < 0) { > + code snip > + } > + #endif > > Is this ok? I think so. If we were able to do everything on runtime, then we could proceed removing all #ifdef stuff. However, we need the #ifdef in the header files to select the different internal structures between MX.51 and MX.53. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================