From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 07 Dec 2010 18:39:06 +0100 Subject: [U-Boot] [PATCH v4 2/7] gpio: Add Multi-Function-Pin configuration driver for Marvell SoCs In-Reply-To: References: Message-ID: <4CFE713A.4050203@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 07/12/2010 18:10, Prafulla Wadaskar a ?crit : >>> + val&= ~MFP_AF_MASK; >> Do we need to do this& here? For val is only 0 here... > > This can be removed. OTOH, with the &, this line makes no assumption about val, and thus will work regardless of it. If the & is removed, and if later val is set to non-zero before reaching this instruction, it will cause a bug. IOW, the & makes the statement more resilient. Amicalement, -- Albert.