[U-Boot] [PATCH v4 4/7] jz4740 nand driver

Xiangfu Liu
2011-01-09T10:35:56Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/05/2011 04:16 AM, Scott Wood wrote:
> On Wed, Dec 08, 2010 at 12:20:46AM -0600, Xiangfu Liu wrote:
>> + writel(readl(EMC_NFECR) & ~EMC_NFECR_ECCE, EMC_NFECR);
>
> readl() and other I/O accessors take pointers, not integer addresses.
Hi Scott

I fixed the others error, only this one I don't know how to do that.
can you point me to some example.

thanks for your emails.

> Use I/O accesors.
> U-Boot coding style prohibits declarations mid-block.
> Line length.
> Please symbolically define what went into that magic number.
>
> -Scott
>

- --
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0pj4wACgkQRRAEFRxkgLSOgwCfZV/I0kCA+AT9Vu1OlXm3sZdU
9PQAmQGVlXtBePoD3jo0KPympGLKAxu5
=Y7s7
-----END PGP SIGNATURE-----