From: Deepak Saxena <deepak_saxena@mentor.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Honor /memory/reg node in DTB files
Date: Wed, 08 Dec 2010 10:59:44 -0800 [thread overview]
Message-ID: <4CFFD5A0.3030502@mentor.com> (raw)
In-Reply-To: <20101207152236.434ecd8c@udp111988uds.am.freescale.net>
On 12/07/2010 01:22 PM, Scott Wood wrote:
> On Mon, 6 Dec 2010 16:56:26 -0800
> Deepak Saxena <deepak_saxena@mentor.com> wrote:
>
>> +/*
>> + * Check to see if an valid memory/reg property exists
>> + * in the fdt. If so, we do not overwrite it with what's
>> + * been scanned.
>> + *
>> + * Valid mean all the following:
>> + *
>> + * - Memory node has a device-type of "memory"
>> + * - A reg property exists which:
>> + * + has exactly as many cells as #address-cells + #size-cells
>> + * + provides a range that is within [bi_memstart, bi_memstart +
>> bi_memsize]
>> + */
>
> This will get false positives -- a lot of existing device tree
> templates have something like this:
ACK. The code in the patch actually checks for this, just didn't point
it out in the comments.
~deepak
next prev parent reply other threads:[~2010-12-08 18:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 0:56 [U-Boot] [PATCH] Honor /memory/reg node in DTB files Deepak Saxena
2010-12-07 6:52 ` Wolfgang Denk
2010-12-07 18:05 ` Deepak Saxena
2010-12-07 19:09 ` Wolfgang Denk
2010-12-08 18:30 ` Hollis Blanchard
2010-12-08 20:53 ` Wolfgang Denk
2010-12-08 21:08 ` Hollis Blanchard
2010-12-08 21:38 ` Wolfgang Denk
2010-12-08 22:08 ` Dan Malek
2010-12-08 22:34 ` Wolfgang Denk
2010-12-08 23:33 ` Peter Tyser
2010-12-08 23:59 ` Dan Malek
2010-12-09 10:00 ` Wolfgang Denk
2010-12-10 18:04 ` Deepak Saxena
2010-12-12 21:19 ` Wolfgang Denk
2010-12-08 18:59 ` Deepak Saxena
2010-12-08 21:00 ` Wolfgang Denk
2010-12-07 18:40 ` Hollis Blanchard
2010-12-07 19:21 ` Wolfgang Denk
2010-12-07 21:22 ` Scott Wood
2010-12-08 18:59 ` Deepak Saxena [this message]
2010-12-08 19:11 ` Scott Wood
2010-12-08 19:22 ` Dan Malek
2010-12-08 19:33 ` Scott Wood
2012-03-31 19:32 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFFD5A0.3030502@mentor.com \
--to=deepak_saxena@mentor.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox