From mboxrd@z Thu Jan  1 00:00:00 1970
From: Deepak Saxena <deepak_saxena@mentor.com>
Date: Wed, 08 Dec 2010 10:59:44 -0800
Subject: [U-Boot] [PATCH] Honor /memory/reg node in DTB files
In-Reply-To: <20101207152236.434ecd8c@udp111988uds.am.freescale.net>
References: <4CFD863A.7070000@mentor.com>
	<20101207152236.434ecd8c@udp111988uds.am.freescale.net>
Message-ID: <4CFFD5A0.3030502@mentor.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/07/2010 01:22 PM, Scott Wood wrote:
> On Mon, 6 Dec 2010 16:56:26 -0800
> Deepak Saxena <deepak_saxena@mentor.com> wrote:
> 
>> +/*
>> + * Check to see if an valid memory/reg property exists
>> + * in the fdt. If so, we do not overwrite it with what's
>> + * been scanned.
>> + *
>> + * Valid mean all the following:
>> + *
>> + * - Memory node has a device-type of "memory"
>> + * - A reg property exists which:
>> + *   + has exactly as many cells as #address-cells + #size-cells
>> + *   + provides a range that is within [bi_memstart, bi_memstart + 
>> bi_memsize]
>> + */
> 
> This will get false positives -- a lot of existing device tree
> templates have something like this:

ACK. The code in the patch actually checks for this, just didn't point
it out in the comments.

~deepak