public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] arm920t: fix linker skript for -pie linking
Date: Thu, 09 Dec 2010 08:33:12 +0100	[thread overview]
Message-ID: <4D008638.4060004@aribaud.net> (raw)
In-Reply-To: <7201DCF2-BD44-4437-BC4F-0B07FEE58C30@googlemail.com>

Le 09/12/2010 08:24, Andreas Bie?mann a ?crit :
> Dear Wolfgang Denk,
>
> Am 08.12.2010 um 23:52 schrieb Wolfgang Denk:
>
>> Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,
>>
>> In message<1291099039-49672-4-git-send-email-andreas.devel@googlemail.com>  you wrote:
>>> Without this patch the linker will SEGFAULT on some undefined weak
>>> symbols.
>>>
>>> Suggested-by: Sebastien Carlier<sebastien.carlier@gmail.com>
>>> Signed-off-by: Andreas Bie?mann<andreas.devel@googlemail.com>
>>> ---
>>> arch/arm/cpu/arm920t/u-boot.lds |    3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> Applied, thanks.
>
> Please do not apply that patch! I'm sorry I have split up the thread cause it lead to a generic timer discussion. Therefore I posted v2 of this patch series here:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/89974
>
> This patch is not needed, if no undefined weak symbol is available.
> This patch adds .plt/.rel.plt section which has R_ARM_JUMP_SLOT which is not handled in code. Therefore we do not really know what this patch does to the code, it was mostly a patch to handle the linker segfault described several times.

Thanks for pointing this out. My bad: I did not relate the two series 
when going through patchwork.

Wolfgang, I was about to send out a revert but after pulling u-boot.git 
and u-boot-arm.git I don't see Andreas' patch in there. If you haven't 
committed it yet, maybe you can fix this yourself?

> regards
>
> Andreas Bie?mann

Amicalement,
-- 
Albert.

  reply	other threads:[~2010-12-09  7:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30  6:37 [U-Boot] [PATCH 0/4] get at91rm9200ek working with ARM relocation Andreas Bießmann
2010-11-30  6:37 ` [U-Boot] [PATCH 1/4] at91rm9200ek: add configure target for RAM boot Andreas Bießmann
2010-11-30  6:37 ` [U-Boot] [PATCH 2/4] MAKEALL: fix AT91 Andreas Bießmann
2010-11-30  6:37 ` [U-Boot] [PATCH 3/4] arm920t: fix linker skript for -pie linking Andreas Bießmann
2010-12-08 22:52   ` Wolfgang Denk
2010-12-09  7:24     ` Andreas Bießmann
2010-12-09  7:33       ` Albert ARIBAUD [this message]
2010-12-09  9:45         ` Wolfgang Denk
2010-12-09 10:32           ` Wolfgang Denk
2010-12-09 10:51             ` Andreas Bießmann
2010-11-30  6:37 ` [U-Boot] [PATCH 4/4] arm920t/at91/timer: replace bss variables by gd Andreas Bießmann
2010-11-30  7:17   ` Reinhard Meyer
2010-11-30  8:03     ` Andreas Bießmann
2010-11-30  8:16       ` Wolfgang Denk
2010-11-30  8:48         ` Andreas Bießmann
2010-11-30  9:14         ` [U-Boot] TIMER cleanup RFC, was: " Reinhard Meyer
2010-11-30 15:11           ` J. William Campbell
2010-11-30 15:48             ` Reinhard Meyer
2010-11-30 17:29               ` J. William Campbell
2010-11-30 18:06 ` [U-Boot] [PATCH 0/4] get at91rm9200ek working with ARM relocation Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D008638.4060004@aribaud.net \
    --to=albert@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox