From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 09 Dec 2010 08:33:12 +0100 Subject: [U-Boot] [PATCH 3/4] arm920t: fix linker skript for -pie linking In-Reply-To: <7201DCF2-BD44-4437-BC4F-0B07FEE58C30@googlemail.com> References: <1291099039-49672-1-git-send-email-andreas.devel@googlemail.com> <1291099039-49672-4-git-send-email-andreas.devel@googlemail.com> <20101208225253.266B4CF5CA6@gemini.denx.de> <7201DCF2-BD44-4437-BC4F-0B07FEE58C30@googlemail.com> Message-ID: <4D008638.4060004@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 09/12/2010 08:24, Andreas Bie?mann a ?crit : > Dear Wolfgang Denk, > > Am 08.12.2010 um 23:52 schrieb Wolfgang Denk: > >> Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=, >> >> In message<1291099039-49672-4-git-send-email-andreas.devel@googlemail.com> you wrote: >>> Without this patch the linker will SEGFAULT on some undefined weak >>> symbols. >>> >>> Suggested-by: Sebastien Carlier >>> Signed-off-by: Andreas Bie?mann >>> --- >>> arch/arm/cpu/arm920t/u-boot.lds | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> Applied, thanks. > > Please do not apply that patch! I'm sorry I have split up the thread cause it lead to a generic timer discussion. Therefore I posted v2 of this patch series here: > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/89974 > > This patch is not needed, if no undefined weak symbol is available. > This patch adds .plt/.rel.plt section which has R_ARM_JUMP_SLOT which is not handled in code. Therefore we do not really know what this patch does to the code, it was mostly a patch to handle the linker segfault described several times. Thanks for pointing this out. My bad: I did not relate the two series when going through patchwork. Wolfgang, I was about to send out a revert but after pulling u-boot.git and u-boot-arm.git I don't see Andreas' patch in there. If you haven't committed it yet, maybe you can fix this yourself? > regards > > Andreas Bie?mann Amicalement, -- Albert.