From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] OMAP: Timer: Replace bss variable by gd
Date: Fri, 10 Dec 2010 08:45:02 +0100 [thread overview]
Message-ID: <4D01DA7E.4030108@denx.de> (raw)
In-Reply-To: <4D01D73F.60905@denx.de>
Hello Dirk,
Heiko Schocher wrote:
> Dirk Behme wrote:
>> Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss
>> values in the OMAP timer driver.
>>
>> The usage of bss values in drivers before initialisation of bss is forbidden.
>> In that special case some data in .rel.dyn gets corrupted.
>>
>> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>
>> ---
>>
>> Note: This is compile tested only (therefore the RFC). Please *test*
>> on real OMAP HW, e.g. Beagle.
>
> Works for me on:
>
> U-Boot 2010.12-rc2-00245-g13e984c (Dec 10 2010 - 08:28:22)
> OMAP3530-GP ES3.0, CPU-OPP2, L3-165MHz, Max CPU Clock 600 mHz
> OMAP3 Beagle board + LPDDR/NAND
>
> Thanks!
>
> Tested-by: Heiko Schocher<hs@denx.de>
>
> But mmc does not longer work on my beagle board... searching for it
User error, mmc works fine, sorry for the noise.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2010-12-10 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 16:31 [U-Boot] [RFC PATCH] OMAP: Timer: Replace bss variable by gd Dirk Behme
2010-12-09 23:12 ` John Rigby
2010-12-10 0:06 ` Nishanth Menon
2010-12-10 5:22 ` Dirk Behme
2010-12-10 7:47 ` Wolfgang Denk
2010-12-10 23:48 ` Steve Sakoman
2010-12-10 7:31 ` Heiko Schocher
2010-12-10 7:45 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D01DA7E.4030108@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox