From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm926ejs, timer:
Date: Fri, 10 Dec 2010 09:51:37 +0100 [thread overview]
Message-ID: <4D01EA19.8070200@emk-elektronik.de> (raw)
In-Reply-To: <4D01E898.2080103@emk-elektronik.de>
Sorry for the noise, but...
>>> just looked in the timer implementation for arm926ejs based boards, and
>>> found that there is just the at91, davinci, nomadik timer implementation
>>> fixed in actual u-boot. I want to cleanup this timers too, but
>>> there are kirkwood, mb86r0x, orion5x, spear, versatile archs which use
>>> a lastdec var, which is not in global_data.h defined. So the question
>>> is should we add a lastdec to global_data.h or is it Ok, if I use
>>> lastinc for cleaning up?
>> I would suggest to take tbu, tbl, lastinc out of the AT91FAMILY #ifdef
>> to the generic part.
>
> maybe "unify" last{inc,dec} into last_hw ? Because they are supposedly the
> last (hardware) decrementer/incrementer values from the previous call.
>
define 4 u32's in the generic part:
u32 timer_use1;
u32 timer_use2;
u32 timer_use3;
u32 timer_use4;
and have the timer implementations themselves use defines to make them more readable.
#define lastinc gd->timer_use1
A future AT91 timer might not use tbu/tbl, but would need 4 values to keep track
of 2 independant timers for udelay() and a 1kHz base for *_timer().
Reinhard
next prev parent reply other threads:[~2010-12-10 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 8:16 [U-Boot] arm926ejs, timer: Heiko Schocher
2010-12-10 8:39 ` Reinhard Meyer
2010-12-10 8:45 ` Reinhard Meyer
2010-12-10 8:51 ` Reinhard Meyer [this message]
2010-12-10 9:16 ` Heiko Schocher
2010-12-12 21:16 ` Wolfgang Denk
2010-12-13 0:27 ` Reinhard Meyer
2010-12-13 7:43 ` Albert ARIBAUD
2010-12-16 14:12 ` Wolfgang Denk
2010-12-10 15:50 ` Nick Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D01EA19.8070200@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox