From: Jens Scharsig <js_at_ng@scharsoft.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH alternate version V2] at91rm9200: fix lowlevel_init() SMRDATA size
Date: Sun, 12 Dec 2010 20:12:42 +0100 [thread overview]
Message-ID: <4D051EAA.9020004@scharsoft.de> (raw)
In-Reply-To: <FB960DBB-AB28-461F-956B-109612FA9A39@googlemail.com>
Dear Andreas Bie?mann
> ---8<---
>> @@ -65,7 +65,8 @@ LoopOsc:
>> ldr r0, =SMRDATA
>> ldr r1, _MTEXT_BASE
>> sub r0, r0, r1
>> - add r2, r0, #80
>> + ldr r2, =SMRDATAE
>> + add r2, r2, r1
> --->8---
Ok,this is wrong, But it is code from version 1. The V2 use the correct sub instruction.
>
> Then we subtract TEXT_BASE from absolute address of SMRDATA. This lead to some value about 0x500 in r0 which is completely wrong which in turn leads to data abort. ... It would make sense to me to do some construct like this for relocated code, but here we are before relocation and therefore it would be sufficient to
At boot time flash memory is mapded to 0x0. So the address 0x500 and 0x10000500 points the same location in flash.
>
regards
Jens Scharsig
next prev parent reply other threads:[~2010-12-12 19:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 7:26 [U-Boot] [PATCH] at91rm9200: fix lowlevel_init() SMRDATA size Andreas Bießmann
2010-12-03 17:09 ` Jens Scharsig
2010-12-03 21:22 ` Andreas Bießmann
2010-12-04 11:37 ` Jens Scharsig
2010-12-04 12:04 ` Albert ARIBAUD
2010-12-04 13:14 ` Andreas Bießmann
2010-12-04 18:18 ` Albert ARIBAUD
2010-12-04 10:53 ` [U-Boot] [PATCH alternate version] " Jens Scharsig
2010-12-04 13:12 ` Andreas Bießmann
2010-12-04 13:19 ` Andreas Bießmann
2010-12-05 8:12 ` [U-Boot] [PATCH alternate version V2] " Jens Scharsig
2010-12-05 10:16 ` Reinhard Meyer
2010-12-06 17:36 ` Jens Scharsig
2010-12-06 21:03 ` Andreas Bießmann
2010-12-12 19:12 ` Jens Scharsig [this message]
2010-12-17 7:55 ` Reinhard Meyer
2010-12-23 11:37 ` Andreas Bießmann
2010-12-18 12:30 ` [U-Boot] [PATCH alternate V3] " Jens Scharsig
2010-12-23 11:39 ` Andreas Bießmann
2010-12-23 12:13 ` Reinhard Meyer
2010-12-23 13:05 ` Jens Scharsig
2011-04-11 9:58 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D051EAA.9020004@scharsoft.de \
--to=js_at_ng@scharsoft.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox