From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Thu, 16 Dec 2010 14:34:40 +0100
Subject: [U-Boot] [PATCH 1/5] MX5: Add initial support for MX53
In-Reply-To: <1292494665-25674-2-git-send-email-r64343@freescale.com>
References: <1292494665-25674-1-git-send-email-r64343@freescale.com>
	<1292494665-25674-2-git-send-email-r64343@freescale.com>
Message-ID: <4D0A1570.10300@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/16/2010 11:17 AM, Jason Liu wrote:
> Add initial support for Freescale MX53 processor,
> 
> - Add the iomux support and the pin definition,
> - Add the regs definition, clean up some unused def from mx51,
> - Add the low level init support, make use the freq input of setup_pll macro
> 
> ---
> Changes for v2:
> --address some comments of Stefano Babic,

Please add always the version number in the e-mail subject, if it is a
resubmission, so we can know there is a previous version. Please add a
small list with all changes, as I cannot know which of them you implemented.

> diff --git a/arch/arm/cpu/armv7/mx5/soc.c b/arch/arm/cpu/armv7/mx5/soc.c
> index 2900119..f5e0283 100644
> --- a/arch/arm/cpu/armv7/mx5/soc.c
> +++ b/arch/arm/cpu/armv7/mx5/soc.c
> @@ -35,6 +35,8 @@
>  
>  #if defined(CONFIG_MX51)
>  #define CPU_TYPE 0x51000
> +#elif defined(CONFIG_MX53)
> +#define CPU_TYPE 0x53000
>  #else
>  #error "CPU_TYPE not defined"
>  #endif

In the previous discussion on first submit it seemd to me you agreed to
change this part, as we have already CONFIG_MX51 and CONFIG_MX53 and
additional defines are not needed. However, you resubmit the same code.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================