From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 21 Dec 2010 07:17:43 +0100 Subject: [U-Boot] [PATCH] Move DECLARE_GLOBAL_DATA_PTR to file scope In-Reply-To: <1292894871-1436-1-git-send-email-john.rigby@linaro.org> References: <1292894871-1436-1-git-send-email-john.rigby@linaro.org> Message-ID: <4D104687.4030104@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 21/12/2010 02:27, John Rigby a ?crit : > It can be optimised out by the compiler otherwise resulting > in obscure errors like a board not booting. > > This has been documented in README since 2006 when these were > first fixed up for GCC 4.x. > > Signed-off-by: John Rigby > --- I think this should be considered a bug fix and a potent(ial) help in getting as many ARM boards working as possible, and so should be put in v2010.12 if still possible. Amicalement, -- Albert.