From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] microblaze: Fix bdiinfo pointer
Date: Tue, 21 Dec 2010 14:51:17 +0100 [thread overview]
Message-ID: <4D10B0D5.2050707@monstr.eu> (raw)
In-Reply-To: <20101221134810.AE01B126EB19@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Michal Simek,
>
> In message <4D10A473.2030202@monstr.eu> you wrote:
>> I would like to do it but it is not easy to use sizeof because there are
>> some dependencies in macros in common.h(lines 193-201) because I am
>> using CONFIG_SYS_GBL_DATA_OFFSET for monitor/malloc areas.
>>
>> The best will be to be able to generate this value in lib/asm-offsets.c
>>
>> Not sure if you are ok with it.
>
> Yes, this is OK.
>
>> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c
>> index 2209561..36fc198 100644
>> --- a/lib/asm-offsets.c
>> +++ b/lib/asm-offsets.c
>> @@ -24,6 +24,8 @@ int main(void)
>> /* Round up to make sure size gives nice stack alignment */
>> DEFINE(GENERATED_GBL_DATA_SIZE,
>> (sizeof(struct global_data)+15) & ~15);
>> + DEFINE(GENERATED_BD_INFO_SIZE,
>> + (sizeof(struct bd_info)+15) & ~15);
>>
>> return 0;
>> }
>
> This patch is white-space corrupted, though.
It wasn't intended as a patch just show if this approach will be acceptable.
I will generate patches based on this.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2010-12-21 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 12:09 [U-Boot] Microblaze fixes Michal Simek
2010-12-21 12:09 ` [U-Boot] [PATCH 1/2] microblaze: Disabling interrupt should return 1 if implemented Michal Simek
2010-12-21 12:09 ` [U-Boot] [PATCH 2/2] microblaze: Fix bdiinfo pointer Michal Simek
2010-12-21 12:26 ` Wolfgang Denk
2010-12-21 12:58 ` Michal Simek
2010-12-21 13:48 ` Wolfgang Denk
2010-12-21 13:51 ` Michal Simek [this message]
2010-12-21 12:24 ` [U-Boot] [PATCH 1/2] microblaze: Disabling interrupt should return 1 if implemented Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D10B0D5.2050707@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox