From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style
Date: Tue, 21 Dec 2010 21:02:26 +0100 [thread overview]
Message-ID: <4D1107D2.7070607@monstr.eu> (raw)
In-Reply-To: <20101221185553.8A2E7126EB1A@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Michal Simek,
>
> In message <1292955178-13018-1-git-send-email-monstr@monstr.eu> you wrote:
>> Clear coding style issues.
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>> lib/asm-offsets.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c
>> index 2209561..f1af7e2 100644
>> --- a/lib/asm-offsets.c
>> +++ b/lib/asm-offsets.c
>> @@ -19,11 +19,11 @@
>>
>> #include <linux/kbuild.h>
>>
>> -int main(void)
>> +int main (void)
>> {
>> /* Round up to make sure size gives nice stack alignment */
>> - DEFINE(GENERATED_GBL_DATA_SIZE,
>> - (sizeof(struct global_data)+15) & ~15);
>> + DEFINE (GENERATED_GBL_DATA_SIZE,
>> + (sizeof (struct global_data) + 15) & ~15);
>
> These changes are to the worse. All. Why do you think this would be
> better?
It is what intend suggest to do.
intend -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1 -pcs
I am OK to remove space between macro name and argument as you suggested
in your other email.
>> + DEFINE (GENERATED_GBL_DATA_SIZE,
>> + (sizeof (struct global_data) + 15) & ~15);
^ ^ ^ ^
I believe that marked space are OK, or not?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2010-12-21 20:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 18:12 [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style Michal Simek
2010-12-21 18:12 ` [U-Boot] [PATCH 2/3] Autogenerate GENERATED_BD_INFO_SIZE Michal Simek
2010-12-21 18:12 ` [U-Boot] [PATCH 3/3] microblaze: Fix bdiinfo pointer Michal Simek
2010-12-21 19:01 ` Wolfgang Denk
2010-12-21 20:45 ` Michal Simek
2010-12-21 21:15 ` Wolfgang Denk
2010-12-21 18:56 ` [U-Boot] [PATCH 2/3] Autogenerate GENERATED_BD_INFO_SIZE Wolfgang Denk
2010-12-21 18:55 ` [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style Wolfgang Denk
2010-12-21 20:02 ` Michal Simek [this message]
2010-12-21 21:11 ` Wolfgang Denk
2010-12-22 6:39 ` Michal Simek
2010-12-22 7:00 ` Wolfgang Denk
2010-12-22 7:19 ` Michal Simek
2010-12-22 11:38 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1107D2.7070607@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox